From: Andrew Dunstan <andrew@dunslane.net>
To: Thomas Munro <thomas.munro@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
Date: Tue, 11 Jan 2022 16:44:15 -0500
Message-ID: <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net> (raw)
In-Reply-To: <CA+hUKGLpuR87F7s7GCkCn9Qs0GMyLJYvRYxf_zQJPw==t+uE0g@mail.gmail.com>
References: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
<2760528.1641929756@sss.pgh.pa.us>
<CA+hUKGLpuR87F7s7GCkCn9Qs0GMyLJYvRYxf_zQJPw==t+uE0g@mail.gmail.com>
On 1/11/22 16:22, Thomas Munro wrote:
> 2. headerscheck and cpluspluscheck don't like it, at least
>> not on non-Windows:
>>
>> $ src/tools/pginclude/headerscheck
>> In file included from /tmp/headerscheck.WKh8cz/test.c:2:
>> ./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such file or directory
>> #include <ntstatus.h>
>> ^~~~~~~~~~~~
>>
>> One way to solve that, perhaps, is to wrap the whole header
>> in #ifdef WIN32. But I think our more usual practice has
>> been to add such headers to the exclusion lists in those
>> two scripts.
> Done.
>
> Those scripts aren't really on my radar... would it be a good idea to
> run them as steps in the CompilerWarnings CI task?
>
>
Or in a buildfarm module (c.f. the perl checks)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
In-Reply-To: <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox