From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
Date: Mon, 18 Jul 2022 18:20:44 -0400
Message-ID: <840982.1658182844@sss.pgh.pa.us> (raw)
In-Reply-To: <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
References: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
<20220718211408.o2uyu5kvud56ihlj@awork3.anarazel.de>
<822625.1658179641@sss.pgh.pa.us>
<20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de>
<838180.1658181982@sss.pgh.pa.us>
<20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2022-07-18 18:06:22 -0400, Tom Lane wrote:
>> I took it out and fixed the half-dozen places where I got warnings,
>> as attached.
> Grepping for 'no warnings' shows that check_rules.pl has the same
> issue. Perhaps worth fixing at the same time, given how closely related they
> are?
Ah, I didn't think to look around. I'll see what I can do there.
>> Seem like a good fix?
> Looks good to my not-perl-trained eyes.
Yeah, I'm more worried about non-idiomatic usage than whether
it works or not.
> Might be worth making sure the output files are the same before / after? You
> probably already checked...
Yup, I did.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, andrew@dunslane.net
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
In-Reply-To: <840982.1658182844@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox