From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: Tue, 08 Apr 2025 10:24:21 -0400
Message-ID: <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de> (raw)
In-Reply-To: <3976705.1744121148@sss.pgh.pa.us>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
<7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
<3976705.1744121148@sss.pgh.pa.us>
Hi,
On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas.vondra@postgresql.org> wrote:
>>> Add support for basic NUMA awareness
>
>> dogfish is a little bit upset it seems.
>
>Hm, but why isn't anything else?
I assume it's a question of degree of parallelism. I was able to repro the failure when building from a clean tree with unlimited parallelism.
>I noticed this a little further up in dogfish's log:
>
>ninja: bad depfile: expected ':', saw 's'
I noticed that too - but it happened even before the hard failures. Will look at it in a bit.
>> Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
>> FRONTEND guard for postgres_fe.h as well?
>
>No, because it's evidently backend-only code. The real question
>is why is it in src/port/, because everything there gets built
>for both frontend and backend.
I think part of the file would make sense to eventually use in FE code, we should move the SQL function and the page size function out.
Greetings,
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, daniel@yesql.se, tomas.vondra@postgresql.org
Subject: Re: pgsql: Add support for basic NUMA awareness
In-Reply-To: <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox