pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: ilmari@ilmari.org
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Sun, 05 Jan 2020 13:35:03 +0000
Message-ID: <87k16610xk.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <1888.1578190678@sss.pgh.pa.us>
References: <20200103170226.GB32629@msg.df7cb.de>
	<CA+TgmoZsPe_G1ssO6KVPqbMQHDEz=vHPQH1jxaSjpG_QxM7wUg@mail.gmail.com>
	<CAH2-WznPzfWHu8PQwv1Qjpf4wQVPaaWpoO5NunFz9zsYKB4uJA@mail.gmail.com>
	<22669.1578104202@sss.pgh.pa.us>
	<CAH2-WznyU3QxzRr12W_tJAzjwM9qd6bh_ZGx3Xupk3RqE1t72A@mail.gmail.com>
	<25298.1578106280@sss.pgh.pa.us>
	<CAH2-Wzkq4OELzn3yZvuqsPuso5JfSXdaD+yW=1VMz2YpXTBYxA@mail.gmail.com>
	<CAH2-Wzk3xfc53A0KZRe4Xu9TALRU=HSfSVZqx3jBuws08mG-ew@mail.gmail.com>
	<3055.1578115809@sss.pgh.pa.us>
	<CAH2-Wz=CtOruqXPd3naWXNiQ0WvLSFnCDYmSDWy0hKiLrppXDQ@mail.gmail.com>
	<8038.1578119995@sss.pgh.pa.us>
	<CAH2-Wz=f4B9+Ob-51-5z9G8a9LmztNpgo0YbKuTjxus3kFjpCg@mail.gmail.com>
	<9256.1578121229@sss.pgh.pa.us>
	<25739.1578161968@sss.pgh.pa.us>
	<22817.1578167447@sss.pgh.pa.us>
	<CAH2-Wz=4U_qKeLjN2FnLmSON8B5DgpMNXRdR4mLzgZjdpaMfUg@mail.gmail.com>
	<26857.1578183240@sss.pgh.pa.us>
	<CAH2-Wz=mJPd5cZwUdHGQ5sQsz6X58DivewER_WQ2+bx_ZU6yGw@mail.gmail.com>
	<912.1578189448@sss.pgh.pa.us>
	<CAH2-WzkicOOPb2AHa+PSeQ1-N3qUV-0TKMX=EHVi55eH5Rtj9A@mail.gmail.com>
	<1888.1578190678@sss.pgh.pa.us>

Tom Lane <tgl@sss.pgh.pa.us> writes:

> Cool, I'll go commit a fix along those lines.  Thanks for tracing
> this down!

Here's one final style cleanup for the TAP test.

- use like() for the banner test
- pass the regexes around as qr// objects, so they can be
  syntax-highlighted properly, and don't need regex
  metacharacter-escaping backslashes doubled.
- include the regex that didn't match in the diagnostic

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law






view thread (64+ messages)  latest in thread

Message-ID: <87k16610xk.fsf@wibble.ilmari.org>
Permalink:  ../87k16610xk.fsf@wibble.ilmari.org/
Also on:    postgresql.org/message-id/87k16610xk.fsf@wibble.ilmari.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: ilmari@ilmari.org, tgl@sss.pgh.pa.us, pg@bowt.ie, robertmhaas@gmail.com, myon@debian.org, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
  In-Reply-To: <87k16610xk.fsf@wibble.ilmari.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox