pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
Date: Tue, 14 Jun 2022 13:23:04 -0400
Message-ID: <90595.1655227384@sss.pgh.pa.us> (raw)
In-Reply-To: <E1nxKKP-002beU-Ef@gemulon.postgresql.org>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org>

Michael Paquier <michael@paquier.xyz> writes:
> Force run of pg_upgrade in the build directory in its TAP test

This commit removed delete_old_cluster.sh etc. from .gitignore,
but they are still generated in the current directory, so after
running a test in a non-VPATH setup I see

$ git status
...
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        delete_old_cluster.sh

I suppose it would be too user-unfriendly to generate those scripts
underneath $PGDATA, so don't we need to put back the .gitignore
entries?

			regards, tom lane





view thread (5+ messages)  latest in thread

Message-ID: <90595.1655227384@sss.pgh.pa.us>
Permalink:  ../90595.1655227384@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/90595.1655227384@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz
  Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
  In-Reply-To: <90595.1655227384@sss.pgh.pa.us>
  References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org> <90595.1655227384@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox