pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
Date: Wed, 15 Jun 2022 09:48:14 +0900
Message-ID: <YqksTlm+89FwXWzz@paquier.xyz> (raw)
In-Reply-To: <191585.1655251919@sss.pgh.pa.us>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org>
	<90595.1655227384@sss.pgh.pa.us>
	<YqkhANbVO13UNXxR@paquier.xyz>
	<191585.1655251919@sss.pgh.pa.us>

On Tue, Jun 14, 2022 at 08:11:59PM -0400, Tom Lane wrote:
> Sorry, I wasn't very clear: I'd tested pg_upgrade with a manual
> invocation, like "./pg_upgrade -d ...".  That used to be OK and
> now it leaves junk around.  I think it's worth keeping the
> .gitignore entries (and I guess the "make clean" rule step too)
> so that that approach still works without making a mess.

No big deal to me to add that both the .gitignore entry and the
cleanup rule if that's annoying for some.  FWIW, I just have some
scripts lying around to launch my upgrade commands in isolated paths,
pretty much like the TAP tests.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (5+ messages)

Message-ID: <YqksTlm+89FwXWzz@paquier.xyz>
Permalink:  ../YqksTlm+89FwXWzz@paquier.xyz/
Also on:    postgresql.org/message-id/YqksTlm+89FwXWzz@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
  In-Reply-To: <YqksTlm+89FwXWzz@paquier.xyz>
  References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org> <90595.1655227384@sss.pgh.pa.us> <YqkhANbVO13UNXxR@paquier.xyz> <191585.1655251919@sss.pgh.pa.us> <YqksTlm+89FwXWzz@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox