pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
Date: Sun, 18 Sep 2022 00:47:39 -0400
Message-ID: <92291.1663476459@sss.pgh.pa.us> (raw)
In-Reply-To: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org>
References: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org>

Peter Geoghegan <pg@bowt.ie> writes:
> Harmonize reorderbuffer parameter names.

I'm confused about this, because it didn't fix the (ahem) poster-child
case?

-extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, TransactionId, XLogRecPtr commit_lsn);
-extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, TransactionId,
+extern void ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid,
+                                    TransactionId subxid, XLogRecPtr lsn);
+extern void ReorderBufferCommitChild(ReorderBuffer *rb, TransactionId, TransactionId,
                                     XLogRecPtr commit_lsn, XLogRecPtr end_lsn);

ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still
short some parameter names.

			regards, tom lane





view thread (7+ messages)  latest in thread

Message-ID: <92291.1663476459@sss.pgh.pa.us>
Permalink:  ../92291.1663476459@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/92291.1663476459@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie
  Subject: Re: pgsql: Harmonize reorderbuffer parameter names.
  In-Reply-To: <92291.1663476459@sss.pgh.pa.us>
  References: <E1oZi3m-000pD8-Gb@gemulon.postgresql.org> <92291.1663476459@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox