pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <daniel@yesql.se>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Noah Misch <noah@leadboat.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 7 Oct 2021 21:51:49 +0200
Message-ID: <AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se> (raw)
In-Reply-To: <173186.1633635888@sss.pgh.pa.us>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org>
	<150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
	<161525.1633632402@sss.pgh.pa.us>
	<162421.1633633360@sss.pgh.pa.us>
	<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
	<173186.1633635888@sss.pgh.pa.us>

> On 7 Oct 2021, at 21:44, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> 
> [ cc'ing Craig and Noah, as author/committer of the existing text ]
> 
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 7 Oct 2021, at 21:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> BTW, looking at that a second time, I wonder if that advice is
>>> really of any use.
> 
>> Yeah, I would have to agree.  Reading that again I think what it perhaps should
>> be saying is that 5.8.3 is the Perl API level that the testcode must conform
>> to, but they should run with basically whichever recent Perl you have handy as
>> long as the required modules are installed.  Not that we expect developers to
>> run 5.8.3 when executing TAP tests.
> 
> Yeah.  I propose that what might be more useful than the existing last
> section of src/test/perl/README is something along the lines of:
> 
>  Avoid using any bleeding-edge Perl features.  We have buildfarm
>  animals running Perl versions as old as 5.8.3, so your tests will
>  be expected to pass on that.
> 
>  Also, do not use any non-core Perl modules except IPC::Run.
>  Or, if you must do so for a particular test, arrange to skip
>  the test when the needed module isn't present.

Agreed, that's a lot more helpful.  Since the set of core Perl modules change
over time as modules are brought in (at least that's my understanding of it),
that last paragraph might want to discourage use of modules that aren't
expected to be in-core in commonly used systems?  It might be overthinking it
though.

--
Daniel Gustafsson		https://vmware.com/






view thread (33+ messages)  latest in thread

Message-ID: <AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se>
Permalink:  ../AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se/
Also on:    postgresql.org/message-id/AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com, noah@leadboat.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se>
  References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org> <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <AF18F762-F3A8-4B52-8A32-54CD318D5977@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox