pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date: Thu, 21 May 2015 07:41:37 -0400
Message-ID: <B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com> (raw)
In-Reply-To: <10660.1432171328@sss.pgh.pa.us>
References: <E1YqZCW-0000e6-Od@gemulon.postgresql.org>
	<20150520215816.GI5885@postgresql.org>
	<CAM3SWZRUhr1806zsF28CVRrB=b4t8PWv8d9x29z02xTQoFDyWA@mail.gmail.com>
	<20150520220911.GK5885@postgresql.org>
	<CAM3SWZQXP3Z=iXQ_+HwoqG7417JYf6HKDTmgk-4Xt05OEL_S_Q@mail.gmail.com>
	<CAM3SWZT0Rex4CpZo+re_m2Dh7wunMNsbD-9ZSWWx=JSewW3OVg@mail.gmail.com>
	<20150521011229.GX27868@alap3.anarazel.de>
	<10660.1432171328@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On May 20, 2015, at 9:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
>> You realize there's other instances of this in the same damn function?
> 
> Not to mention that several places in libpq/fe-exec.c should be
> taught about this new tag.  And who-knows-what in other client-side
> libraries.  I am not really sure that it was a good idea to invent
> this command tag.  In fact, I'm pretty sure it was a *bad* idea ---
> what will happen if we ever create a statement actually named UPSERT?
> 
> I think we should fix this by ripping out the variant tag, not trying
> to propagate it everywhere it would need to go.

+1

...Robert


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (32+ messages)  latest in thread

Message-ID: <B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com>
Permalink:  ../B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com/
Also on:    postgresql.org/message-id/B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: robertmhaas@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, pg@heroku.com, alvherre@2ndquadrant.com, pgsql-hackers@postgresql.org
  Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
  In-Reply-To: <B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox