From: Daniel Gustafsson <daniel@yesql.se>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails.
Date: Wed, 3 Nov 2021 20:27:33 +0100
Message-ID: <BFA50363-C235-4C75-9CE1-3AE6333B6F60@yesql.se> (raw)
In-Reply-To: <ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi>
References: <E1miCof-0006bt-DZ@gemulon.postgresql.org>
<DBA08346-9962-4706-92D1-230EE5201C10@yesql.se>
<ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi>
> On 3 Nov 2021, at 18:47, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>
> On 03/11/2021 13:06, Daniel Gustafsson wrote:
>>> On 3 Nov 2021, at 10:44, Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:
>>> Fix snapshot reference leak if lo_export fails.
>> This commit seems to lack the update in largeobject_1 as per hamerkop in:
>
> Fixed, thanks!
>
> I'm a bit surprised none of the other Windows systems on the buildfarm complained. The difference in largeobject_1 output is apparently that the 'tenk.data' file uses Windows line endings. I guess that on all the other Windows hosts, git has been configured to use Unix line endings.
Interesting, so when hamerkop is offline (which it was for a month) we don't
have coverage for Windows line endings? That's worth keeping in mind.
--
Daniel Gustafsson https://vmware.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, hlinnaka@iki.fi
Subject: Re: pgsql: Fix snapshot reference leak if lo_export fails.
In-Reply-To: <BFA50363-C235-4C75-9CE1-3AE6333B6F60@yesql.se>
References: <E1miCof-0006bt-DZ@gemulon.postgresql.org> <DBA08346-9962-4706-92D1-230EE5201C10@yesql.se> <ff9c8400-382f-44c5-1729-8c759e7870ff@iki.fi> <BFA50363-C235-4C75-9CE1-3AE6333B6F60@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox