agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <daniel@yesql.se>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Masao Fujii <masao.fujii@gmail.com>
Subject: Re: pgsql: Revert online data checksum transitions
Date: Wed, 16 Sep 2026 14:43:15 +0200
Message-ID: <C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se> (raw)
In-Reply-To: <CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
References: <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
<1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
<CAJ7c6TOJnA7V7gQXa6WpdNUwtjzH+2Dd6yW8mtMO-KttPWp4+w@mail.gmail.com>
> On 16 Sep 2026, at 14:32, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
>>> We should remove data_page_checksum_version from the pg_control_checkpoint
>>> entry in pg_proc.dat and reduce proargmodes from 20 output columns to 19?
>>
>> Ugh, I thought I had tested everything but clearly missed this one. Will fix immediately when back from lunch.
>
> I noticed that the revert was applied to REL_19_STABLE but not the
> master branch. Just wanted to make sure that's the plan.
That's indeed the plan. The remaining issue that a user can, under the right
set of circumstances, get a false positive page verification in an orphaned
file failure during base backup. The warning is harmless for data integrity,
but is non-trivial for the user to resolve since we don't provide any tools for
dealing with orphaned files. Fixing this in master will reduce churn.
--
Daniel Gustafsson
view thread (19+ messages) latest in thread
Message-ID: <C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se>
Permalink: ../C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se/
Also on: postgresql.org/message-id/C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, aleksander@tigerdata.com, pgsql-hackers@lists.postgresql.org, masao.fujii@gmail.com
Subject: Re: pgsql: Revert online data checksum transitions
In-Reply-To: <C8AD0CF7-1B98-4AC2-B0F3-EC6702C81482@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox