pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <amit.kapila16@gmail.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
Date: Fri, 25 Oct 2019 15:20:09 +0530
Message-ID: <CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com> (raw)
In-Reply-To: <87h83xmg4m.fsf@news-spur.riddles.org.uk>
References: <E1iNpHW-000855-1u@gemulon.postgresql.org>
	<20191025031702.GD8671@paquier.xyz>
	<CAA4eK1JfDfKvjSYOoQFHu=sSzaqdDTR+JZkZqJkvVnueFJPG5g@mail.gmail.com>
	<CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com>
	<87h83xmg4m.fsf@news-spur.riddles.org.uk>

On Fri, Oct 25, 2019 at 1:30 PM Andrew Gierth
<andrew@tao11.riddles.org.uk> wrote:
>
> >>>>> "Amit" == Amit Kapila <amit.kapila16@gmail.com> writes:
>
>  Amit> BTW, prairiedog is also show similar failure and both seems to
>  Amit> have similar OS except for versions.
>
> Be aware that prairiedog and locust (unlike the rest of the buildfarm)
> have compilers whose "bool" type is not 1 byte long; PG can't use that,
> so we don't include <stdbool.h> on those platforms.
>
> Looking at c.h, the problem seems to be that when we define our own bool
> in the absence of a usable stdbool.h, we do so as a typedef and not a
> macro. So pgtypeslib_extern.h ends up redefining it in that case, and
> (this bit may be my fault: see d26a810eb) uses a different type to c.h
> (char vs. unsigned char).
>
> (stdbool.h is required by spec to do #define bool _Bool rather than a
> typedef, hence the difference in behavior)
>
> I'm no expert on the ECPG internals, but this doesn't look like an
> exposed interface, so maybe it just shouldn't be trying to #define bool
> at all and just rely on c.h (from postgres_fe.h) to declare the type?
>

+1.  I think we can discuss this on hackers, so started a thread [1].

[1] - https://www.postgresql.org/message-id/CAA4eK1LmaKO7Du9M9Lo%3DkxGU8sB6aL8fa3sF6z6d5yYYVe3BuQ%40mail.g...

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com





view thread (17+ messages)  latest in thread

Message-ID: <CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com>
Permalink:  ../CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com/
Also on:    postgresql.org/message-id/CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: amit.kapila16@gmail.com, andrew@tao11.riddles.org.uk, michael@paquier.xyz, akapila@postgresql.org
  Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
  In-Reply-To: <CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com>
  References: <E1iNpHW-000855-1u@gemulon.postgresql.org> <20191025031702.GD8671@paquier.xyz> <CAA4eK1JfDfKvjSYOoQFHu=sSzaqdDTR+JZkZqJkvVnueFJPG5g@mail.gmail.com> <CAA4eK1+Rvft5SgGnBfGdNCVMspDMiXEo=i7Ue2e9Pm0bbOC3jA@mail.gmail.com> <87h83xmg4m.fsf@news-spur.riddles.org.uk> <CAA4eK1+jAz56XPLOVNdx+xFogTNi9AmE6F0smzoUmXhkkGGmLQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox