From: Magnus Hagander <magnus@hagander.net>
To: Andres Freund <andres@anarazel.de>
To: Michael Banck <michael.banck@credativ.de>
To: David Steele <david@pgmasters.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Validate page level checksums in base backups
Date: Tue, 3 Apr 2018 19:17:16 +0200
Message-ID: <CABUevExQa00NOeZd7N7faSZOnL+gtThKSDv2d5zxAP7Cp9YtLA@mail.gmail.com> (raw)
In-Reply-To: <20180403171356.v4ji5sfhbc4sggij@alap3.anarazel.de>
References: <E1f3KUE-0003rM-6g@gemulon.postgresql.org>
<20180403171356.v4ji5sfhbc4sggij@alap3.anarazel.de>
On Tue, Apr 3, 2018 at 7:13 PM, Andres Freund <andres@anarazel.de> wrote:
> On 2018-04-03 11:52:26 +0000, Magnus Hagander wrote:
> > Validate page level checksums in base backups
> >
> > When base backups are run over the replication protocol (for example
> > using pg_basebackup), verify the checksums of all data blocks if
> > checksums are enabled. If checksum failures are encountered, log them
> > as warnings but don't abort the backup.
> >
> > This becomes the default behaviour in pg_basebackup (provided checksums
> > are enabled on the server), so add a switch (-k) to disable the checks
> > if necessary.
> >
> > Author: Michael Banck
> > Reviewed-By: Magnus Hagander, David Steele
> > Discussion: https://postgr.es/m/20180228180856.GE13784@
> nighthawk.caipicrew.dd-dns.de
>
> Hm, something isn't quite right with the test:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=
> pogona&dt=2018-04-03%2016%3A10%3A01
>
> # WARNING: 6 total checksum verification failures
> # pg_basebackup: checksum error occured
> # '
> # doesn't match '(?^s:^WARNING.*7 total checksum verification
> failures)'
>
Yeah, there's clearly a second problem here.
I'm stuck in meetings most of tonight, so I might not get to it right away.
If someonen else figures it out meanwhile please do, otherwise I'll get to
it as soon as I can.
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: magnus@hagander.net, andres@anarazel.de, michael.banck@credativ.de, david@pgmasters.net, pgsql-hackers@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Validate page level checksums in base backups
In-Reply-To: <CABUevExQa00NOeZd7N7faSZOnL+gtThKSDv2d5zxAP7Cp9YtLA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox