pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix for make unportability
3+ messages / 3 participants
[nested] [flat]

* pgsql: Fix for make unportability
@ 2022-07-13 07:18 Peter Eisentraut <peter@eisentraut.org>
  2022-07-13 07:45 ` Re: pgsql: Fix for make unportability Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 1 reply; 3+ messages in thread

From: Peter Eisentraut @ 2022-07-13 07:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix for make unportability

88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
construct that apparently confuses older GNU make versions (possibly
because of the # inside the shell command?).  This construct, which
would allow # comments inside LINGUAS files, was adapted from gettext
recommendations, but we don't actually need that functionality, so
sidestep this whole issue by just using plain "cat".

In passing, make this code work with vpath.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/58b4f366c0c4b3a5d65269f01150e4ec04cb20a2

Modified Files
--------------
src/nls-global.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Fix for make unportability
  2022-07-13 07:18 pgsql: Fix for make unportability Peter Eisentraut <peter@eisentraut.org>
@ 2022-07-13 07:45 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-07-13 10:17   ` Re: pgsql: Fix for make unportability Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  0 siblings, 1 reply; 3+ messages in thread

From: Alvaro Herrera @ 2022-07-13 07:45 UTC (permalink / raw)
  To: Peter Eisentraut <peter@eisentraut.org>; +Cc: pgsql-committers@lists.postgresql.org

On 2022-Jul-13, Peter Eisentraut wrote:

> Fix for make unportability
> 
> 88dad06b47eb80f699211c9b0b7a1c6d9016ad19 contains a make $(shell)
> construct that apparently confuses older GNU make versions (possibly
> because of the # inside the shell command?).  This construct, which
> would allow # comments inside LINGUAS files, was adapted from gettext
> recommendations, but we don't actually need that functionality, so
> sidestep this whole issue by just using plain "cat".

I suppose if we're getting rid of Make soon, it's not really very useful
to make this more make-ish:

  AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS)

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Fix for make unportability
  2022-07-13 07:18 pgsql: Fix for make unportability Peter Eisentraut <peter@eisentraut.org>
  2022-07-13 07:45 ` Re: pgsql: Fix for make unportability Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-07-13 10:17   ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2022-07-13 10:17 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org

On 13.07.22 09:45, Alvaro Herrera wrote:
> I suppose if we're getting rid of Make soon
(we are not)

 > it's not really very useful> to make this more make-ish:
> 
>    AVAIL_LANGUAGES := $(file <$(srcdir)/po/LINGUAS)

I had never seen this syntax.  The GNU make changelog reveals that it is 
new in version 4.2 (22 May 2016), which is too new for us to require.





^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-07-13 10:17 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 07:18 pgsql: Fix for make unportability Peter Eisentraut <peter@eisentraut.org>
2022-07-13 07:45 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-07-13 10:17   ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox