pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix the display of UNKNOWN message type in apply worker.
5+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2023-07-25 62e9af4c63  Fix code indentation vioaltion introduced in commit d38ad8e31d.
* pgsql: Fix the display of UNKNOWN message type in apply worker.
@ 2023-07-25 03:52 Amit Kapila <akapila@postgresql.org>
  2023-07-25 05:20 ` Re: pgsql: Fix the display of UNKNOWN message type in apply worker. Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 5+ messages in thread

From: Amit Kapila @ 2023-07-25 03:52 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the display of UNKNOWN message type in apply worker.

We include the message type while displaying an error context in the
apply worker. Now, while retrieving the message type string if the
message type is unknown we throw an error that will hide the original
error. So, instead, we need to simply return the string indicating an
unknown message type.

Reported-by: Ashutosh Bapat
Author: Euler Taveira, Amit Kapila
Reviewed-by: Ashutosh Bapat
Backpatch-through: 15
Discussion: https://postgr.es/m/CAExHW5suAEDW-mBZt_qu4RVxWZ1vL54-L+ci2zreYWebpzxYsA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d38ad8e31dee1a69f4f6d4b6bb4e007e3751a93c

Modified Files
--------------
src/backend/replication/logical/proto.c  | 13 ++++++++++---
src/backend/replication/logical/worker.c |  2 +-
src/include/replication/logicalproto.h   |  2 +-
3 files changed, 12 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
  2023-07-25 03:52 pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <akapila@postgresql.org>
@ 2023-07-25 05:20 ` Michael Paquier <michael@paquier.xyz>
  2023-07-25 10:47   ` Re: pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <amit.kapila16@gmail.com>
  0 siblings, 1 reply; 5+ messages in thread

From: Michael Paquier @ 2023-07-25 05:20 UTC (permalink / raw)
  To: Amit Kapila <akapila@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> Fix the display of UNKNOWN message type in apply worker.
> 
> We include the message type while displaying an error context in the
> apply worker. Now, while retrieving the message type string if the
> message type is unknown we throw an error that will hide the original
> error. So, instead, we need to simply return the string indicating an
> unknown message type.

koel is complaining after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
  2023-07-25 03:52 pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <akapila@postgresql.org>
  2023-07-25 05:20 ` Re: pgsql: Fix the display of UNKNOWN message type in apply worker. Michael Paquier <michael@paquier.xyz>
@ 2023-07-25 10:47   ` Amit Kapila <amit.kapila16@gmail.com>
  0 siblings, 0 replies; 5+ messages in thread

From: Amit Kapila @ 2023-07-25 10:47 UTC (permalink / raw)
  To: Michael Paquier <michael@paquier.xyz>; +Cc: Amit Kapila <akapila@postgresql.org>; pgsql-committers@lists.postgresql.org

On Tue, Jul 25, 2023 at 10:51 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> > Fix the display of UNKNOWN message type in apply worker.
> >
> > We include the message type while displaying an error context in the
> > apply worker. Now, while retrieving the message type string if the
> > message type is unknown we throw an error that will hide the original
> > error. So, instead, we need to simply return the string indicating an
> > unknown message type.
>
> koel is complaining after this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
>

Pushed a fix.

-- 
With Regards,
Amit Kapila.





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix the display of UNKNOWN message type in apply worker.
@ 2023-07-25 03:52 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Amit Kapila @ 2023-07-25 03:52 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the display of UNKNOWN message type in apply worker.

We include the message type while displaying an error context in the
apply worker. Now, while retrieving the message type string if the
message type is unknown we throw an error that will hide the original
error. So, instead, we need to simply return the string indicating an
unknown message type.

Reported-by: Ashutosh Bapat
Author: Euler Taveira, Amit Kapila
Reviewed-by: Ashutosh Bapat
Backpatch-through: 15
Discussion: https://postgr.es/m/CAExHW5suAEDW-mBZt_qu4RVxWZ1vL54-L+ci2zreYWebpzxYsA@mail.gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ad486b0eaef4b2fcb7c672fcbf5c2f31eb99ac83

Modified Files
--------------
src/backend/replication/logical/proto.c  | 13 ++++++++++---
src/backend/replication/logical/worker.c |  2 +-
src/include/replication/logicalproto.h   |  2 +-
3 files changed, 12 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix the display of UNKNOWN message type in apply worker.
@ 2023-07-25 03:52 Amit Kapila <akapila@postgresql.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Amit Kapila @ 2023-07-25 03:52 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix the display of UNKNOWN message type in apply worker.

We include the message type while displaying an error context in the
apply worker. Now, while retrieving the message type string if the
message type is unknown we throw an error that will hide the original
error. So, instead, we need to simply return the string indicating an
unknown message type.

Reported-by: Ashutosh Bapat
Author: Euler Taveira, Amit Kapila
Reviewed-by: Ashutosh Bapat
Backpatch-through: 15
Discussion: https://postgr.es/m/CAExHW5suAEDW-mBZt_qu4RVxWZ1vL54-L+ci2zreYWebpzxYsA@mail.gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2864eb977a6e49d4355b679d7e1e54f01a231b80

Modified Files
--------------
src/backend/replication/logical/proto.c  | 13 ++++++++++---
src/backend/replication/logical/worker.c |  2 +-
src/include/replication/logicalproto.h   |  2 +-
3 files changed, 12 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2023-07-25 10:47 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-07-25 03:52 pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <akapila@postgresql.org>
2023-07-25 05:20 ` Michael Paquier <michael@paquier.xyz>
2023-07-25 10:47   ` Amit Kapila <amit.kapila16@gmail.com>
2023-07-25 03:52 pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <akapila@postgresql.org>
2023-07-25 03:52 pgsql: Fix the display of UNKNOWN message type in apply worker. Amit Kapila <akapila@postgresql.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox