pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
Date: Tue, 25 Jul 2023 14:20:48 +0900
Message-ID: <ZL9bsGhthne6FaVV@paquier.xyz> (raw)
In-Reply-To: <E1qO967-001DLd-Rv@gemulon.postgresql.org>
References: <E1qO967-001DLd-Rv@gemulon.postgresql.org>

On Tue, Jul 25, 2023 at 03:52:32AM +0000, Amit Kapila wrote:
> Fix the display of UNKNOWN message type in apply worker.
> 
> We include the message type while displaying an error context in the
> apply worker. Now, while retrieving the message type string if the
> message type is unknown we throw an error that will hide the original
> error. So, instead, we need to simply return the string indicating an
> unknown message type.

koel is complaining after this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-07-25%2004%3A49%3A03
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (5+ messages)  latest in thread

Message-ID: <ZL9bsGhthne6FaVV@paquier.xyz>
Permalink:  ../ZL9bsGhthne6FaVV@paquier.xyz/
Also on:    postgresql.org/message-id/ZL9bsGhthne6FaVV@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix the display of UNKNOWN message type in apply worker.
  In-Reply-To: <ZL9bsGhthne6FaVV@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox