pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Follow-up fixes for "Make all Perl warnings fatal"
3+ messages / 2 participants
[nested] [flat]
* pgsql: Follow-up fixes for "Make all Perl warnings fatal"
@ 2023-12-29 22:56 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 3+ messages in thread
From: Peter Eisentraut @ 2023-12-29 22:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Follow-up fixes for "Make all Perl warnings fatal"
Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
doing regular expression matches against it.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9d49837d7144e27ad8ea8918acb28f9872cb1585
Modified Files
--------------
src/interfaces/libpq/t/004_load_balance_dns.pl | 2 +-
src/test/kerberos/t/001_auth.pl | 4 ++--
src/test/ldap/t/001_auth.pl | 2 +-
src/test/ldap/t/002_bindpasswd.pl | 2 +-
src/test/modules/ldap_password_func/t/001_mutated_bindpasswd.pl | 2 +-
src/test/modules/xid_wraparound/t/001_emergency_vacuum.pl | 2 +-
src/test/modules/xid_wraparound/t/002_limits.pl | 2 +-
src/test/modules/xid_wraparound/t/003_wraparounds.pl | 2 +-
src/test/ssl/t/001_ssltests.pl | 2 +-
src/test/ssl/t/002_scram.pl | 2 +-
src/test/ssl/t/003_sslinfo.pl | 2 +-
11 files changed, 12 insertions(+), 12 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
@ 2024-01-02 14:49 Andrew Dunstan <andrew@dunslane.net>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Dunstan @ 2024-01-02 14:49 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; pgsql-committers@lists.postgresql.org
On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
> Follow-up fixes for "Make all Perl warnings fatal"
>
> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
> doing regular expression matches against it.
This reads a bit oddly to me.
-elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
+elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
I think I would have changed it like this
elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)
which is an idiom we've used elsewhere.
Still, TIMTOWTDI.
cheers
andrew (japh)
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
@ 2024-01-03 12:14 Peter Eisentraut <peter@eisentraut.org>
parent: Andrew Dunstan <andrew@dunslane.net>
0 siblings, 0 replies; 3+ messages in thread
From: Peter Eisentraut @ 2024-01-03 12:14 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; pgsql-committers@lists.postgresql.org
On 02.01.24 15:49, Andrew Dunstan wrote:
>
> On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
>> Follow-up fixes for "Make all Perl warnings fatal"
>>
>> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
>> doing regular expression matches against it.
>
>
> This reads a bit oddly to me.
>
> -elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
> +elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
>
> I think I would have changed it like this
>
> elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)
>
> which is an idiom we've used elsewhere.
I would probably have written it that way, too, but there was already
existing code dealing specifically with PG_TEST_EXTRA that was written
the other way, so I made it match that.
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-01-03 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-12-29 22:56 pgsql: Follow-up fixes for "Make all Perl warnings fatal" Peter Eisentraut <peter@eisentraut.org>
2024-01-02 14:49 ` Andrew Dunstan <andrew@dunslane.net>
2024-01-03 12:14 ` Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox