pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org, Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: pg_upgrade test failure
Date: Tue, 31 Jan 2023 13:04:24 -0800
Message-ID: <F0554EC4-4545-4224-B373-9B01EA8D25F1@anarazel.de> (raw)
In-Reply-To: <CA+hUKGKCVy2=o=d8c2Va6a_3Rpf_KkhUitkWCZ3hzuO2VwLMXA@mail.gmail.com>
References: <CA+hUKG+bk4KGwYT4JrZEdAgNdFm-c8ezTrxf-PacS-npQ_HdSw@mail.gmail.com>
	<YzqBIzMwoBiESmkk@paquier.xyz>
	<CA+hUKGKsdzw06c5nnb=KYG9GmvyykoVpJA_VR3k0r7cZOKcx6Q@mail.gmail.com>
	<Y04mN0ZLNzJywrad@paquier.xyz>
	<20221018043144.GF7745@telsasoft.com>
	<20221018162908.cb3n7tahtekypbkf@awork3.anarazel.de>
	<CA+hUKGKFh-F2fz_18j3N6bKr966gmaJxV40T0qhDwhKkW+291g@mail.gmail.com>
	<20221206181533.pmcz75zbjgvnnzum@awork3.anarazel.de>
	<CA+hUKGJTM5FswRV-_JWzVLdw=Lq1pjNsvGfONRJp=dpR6YR81Q@mail.gmail.com>
	<CA+hUKGLfruDhC_8QRGDoCndsdzDVjrf7TYwgsv+OfoAmK2syEg@mail.gmail.com>
	<20230131172806.GM22427@telsasoft.com>
	<CA+hUKGKCVy2=o=d8c2Va6a_3Rpf_KkhUitkWCZ3hzuO2VwLMXA@mail.gmail.com>

Hi, 

On January 31, 2023 12:54:42 PM PST, Thomas Munro <thomas.munro@gmail.com> wrote:
>On Wed, Feb 1, 2023 at 6:28 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
>> > I pushed the rmtree() change.  Let's see if that helps, or tells us
>> > something new.
>>
>> I found a few failures since then:
>>
>> https://api.cirrus-ci.com/v1/artifact/task/6696942420361216/testrun/build/testrun/pg_upgrade/002_pg_...
>>
>> pg_upgrade: warning: could not remove directory "C:/cirrus/build/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20230131T134931.720/log": Directory not empty
>> pg_upgrade: warning: could not remove directory "C:/cirrus/build/testrun/pg_upgrade/002_pg_upgrade/data/t_002_pg_upgrade_new_node_data/pgdata/pg_upgrade_output.d/20230131T134931.720": Directory not empty
>
>So no change: we didn't see "could not unlink file ...".  So I think
>that means that it was rmtree() that unlinked the file for the *first*
>time, but someone else has it open.
>
>Even though Windows is at this point eroding my love of computers and
>making me consider a new career in, I dunno, carrot farming or
>something, I have one more idea.  Check out this kluge in
>src/bin/pg_upgrade/exec.c:
>
>        /*
>         * "pg_ctl -w stop" might have reported that the server has stopped
>         * because the postmaster.pid file has been removed, but "pg_ctl -w
>         * start" might still be in the process of closing and might still be
>         * holding its stdout and -l log file descriptors open.  Therefore,
>         * try to open the log file a few more times.
>         */
>
>I'm not sure about anything, but if that's what's happening here, then
>maybe the attached would help.  In short, it would make the previous
>theory true (the idea of a second unlink() saving the day).


Maybe we should just handle it by sleeping and retrying, if on windows? Sad to even propose... 
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





view thread (35+ messages)  latest in thread

Message-ID: <F0554EC4-4545-4224-B373-9B01EA8D25F1@anarazel.de>
Permalink:  ../F0554EC4-4545-4224-B373-9B01EA8D25F1@anarazel.de/
Also on:    postgresql.org/message-id/F0554EC4-4545-4224-B373-9B01EA8D25F1@anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, thomas.munro@gmail.com, pryzby@telsasoft.com, michael@paquier.xyz, byavuz81@gmail.com
  Subject: Re: pg_upgrade test failure
  In-Reply-To: <F0554EC4-4545-4224-B373-9B01EA8D25F1@anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox