From: Michael Paquier <michael@paquier.xyz>
To: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
Date: Thu, 14 Oct 2021 13:00:30 +0900
Message-ID: <YWerXvr2L4uO3TBj@paquier.xyz> (raw)
In-Reply-To: <CAH2-WznrTMoZnYG2PW5mnZGdD_1_mzvi955kbuTdO4mmFuBAUA@mail.gmail.com>
References: <E1ma7Ll-0006i4-3r@gemulon.postgresql.org>
<CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com>
<YWepL/jDBoidu/Ek@paquier.xyz>
<CAH2-WznrTMoZnYG2PW5mnZGdD_1_mzvi955kbuTdO4mmFuBAUA@mail.gmail.com>
On Wed, Oct 13, 2021 at 08:54:16PM -0700, Peter Geoghegan wrote:
> On Wed, Oct 13, 2021 at 8:51 PM Michael Paquier <michael@paquier.xyz> wrote:
>>> # Failed test 'handling of unexpected PQresultStatus: matches'
>>> # at t/001_basic.pl line 43.
>>> # 'psql:/home/pg/.psqlrc:56: ERROR: syntax error
>>> # psql:/home/pg/.psqlrc:57: ERROR: syntax error
>>> # LOG: received replication command: START_REPLICATION 0/0
>>> # unexpected PQresultStatus: 8
>>> # '
>>
>> You may also want to fix your local .psqlrc, while on it.
>
> Why, though? It doesn't do this in any other context.
Even for single psql commands in your environment? That would be
surprising that this does not show the same error about lines 56/57 in
/home/pg/.psqlrc, but I guess that's up to you for this part..
It does not change the fact that the test needs to be fixed. TAP
tests should be designed to not be influenced by the external world.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pg@bowt.ie, peter.eisentraut@enterprisedb.com
Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
In-Reply-To: <YWerXvr2L4uO3TBj@paquier.xyz>
References: <E1ma7Ll-0006i4-3r@gemulon.postgresql.org> <CAH2-Wzn8ftvcDPwomn+y04JJzbT=TG7TN=QsmSEATUOW-ZuvQQ@mail.gmail.com> <YWepL/jDBoidu/Ek@paquier.xyz> <CAH2-WznrTMoZnYG2PW5mnZGdD_1_mzvi955kbuTdO4mmFuBAUA@mail.gmail.com> <YWerXvr2L4uO3TBj@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox