pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Date: Wed, 27 Oct 2021 13:15:46 +0900
Message-ID: <YXjScrEwVMW69rSF@paquier.xyz> (raw)
In-Reply-To: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>
References: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>

On Tue, Oct 26, 2021 at 08:41:11PM +0000, Jeff Davis wrote:
> Allow GRANT on pg_log_backend_memory_contexts().
> 
> Remove superuser check, allowing any user granted permissions on
> pg_log_backend_memory_contexts() to log the memory contexts of any
> backend.
> 
> Note that this could allow a privileged non-superuser to log the
> memory contexts of a superuser backend, but as discussed, that does
> not seem to be a problem.

         but will not be sent to the client regardless of
         <xref linkend="guc-client-min-messages"/>.
-        Only superusers can request to log the memory contexts.
        </para></entry>
I don't think that the documentation part of this commit is correct.
This sentence should have been changed to something like the
following:
"This function is restricted to superusers by default, but other users
can be granted EXECUTE to run the function."

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (8+ messages)  latest in thread

Message-ID: <YXjScrEwVMW69rSF@paquier.xyz>
Permalink:  ../YXjScrEwVMW69rSF@paquier.xyz/
Also on:    postgresql.org/message-id/YXjScrEwVMW69rSF@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, jdavis@postgresql.org
  Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
  In-Reply-To: <YXjScrEwVMW69rSF@paquier.xyz>
  References: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org> <YXjScrEwVMW69rSF@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox