From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
Date: Thu, 2 Dec 2021 07:37:49 +0900
Message-ID: <Yaf5PUW259/e7W3D@paquier.xyz> (raw)
In-Reply-To: <1994933.1638392649@sss.pgh.pa.us>
References: <1632478.1638305700@sss.pgh.pa.us>
<887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se>
<1636597.1638308177@sss.pgh.pa.us>
<BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se>
<1686601.1638333261@sss.pgh.pa.us>
<YacT3tm97xziSUFw@paquier.xyz>
<74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se>
<50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se>
<97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se>
<1994933.1638392649@sss.pgh.pa.us>
On Wed, Dec 01, 2021 at 04:04:09PM -0500, Tom Lane wrote:
> I agree that some docs about this would be nice, but I think the rules
> for when to use perl2host are more complex than what you suggest here.
> Perhaps Andrew can clarify.
+When passing a path from the Perl test code to PostgreSQL, like for example
+the path to an SSL certificate, it must be converted for use on the host
+system by using PostgreSQL::Test::Utils::perl2host.
It seems to me that the rule applies to any paths passed down to the C
code of Postgres, then processed by a system call. It would be good
to add some examples of what that is, I guess. Until now, I think
that we have seen:
- Tablespace paths in SQL queries.
- Paths passed down as function arguments, processed in system calls
by frontends (like pg_basebackup and its tablespace map).
- Paths part of connection strings, processed in system calls in
libpq.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, daniel@yesql.se, andrew@dunslane.net
Subject: Re: pgsql: Add TAP tests for contrib/sslinfo
In-Reply-To: <Yaf5PUW259/e7W3D@paquier.xyz>
References: <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <BF937964-0854-49DA-A4F4-51F4287EB304@yesql.se> <1686601.1638333261@sss.pgh.pa.us> <YacT3tm97xziSUFw@paquier.xyz> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> <97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se> <1994933.1638392649@sss.pgh.pa.us> <Yaf5PUW259/e7W3D@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox