pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Christoph Berg <myon@debian.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: Mon, 14 Feb 2022 11:03:44 +0900
Message-ID: <Ygm4gC4ZN3TU0Bqt@paquier.xyz> (raw)
In-Reply-To: <Ygfg+7yePes1X/A9@msg.df7cb.de>
References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org>
	<YgYw25OXV5men8Fj@msg.df7cb.de>
	<YgcDeben8eigBdNZ@paquier.xyz>
	<Ygd0jsxHreT1cig0@msg.df7cb.de>
	<2280644.1644683003@sss.pgh.pa.us>
	<Ygfg+7yePes1X/A9@msg.df7cb.de>

On Sat, Feb 12, 2022 at 05:31:55PM +0100, Christoph Berg wrote:
> To support multiple major versions in parallel, we need
> /usr/lib/postgresql/NN/lib and /usr/share/postgresql/NN, so it's not a
> single $PREFIX. But you are correct, and ./configure supports that.

Yep, I don't quite see the problem, but I don't have the years of
experience in terms of packaging you have, either.  (NB: I use various
--libdir and --bindir combinations that for some of packaging of PG I
maintain for pg_upgrade, but that's not as complex as Debian, I
guess).

> I was confusing that with this: The problem that led to the pg_config
> patch years ago was that we have a /usr/bin/pg_config in
> (non-major-version-dependant) libpq-dev, and
> /usr/lib/postgresql/NN/bin/pg_config in the individual
> postgresql-server-dev-NN packages, and iirc the /usr/bin version
> didn't particularly like the other binaries being in
> /usr/lib/postgresql/NN/bin/.
> 
> I guess it's time to revisit that problem now and see if it can be
> solved more pretty today on our side.

If you can solve that, my take is that it could make things nicer in
the long-run for some of the TAP test facilities.  Still, I'll try to
look at a solution for this thread that does not interact badly with
what you are doing, and I am going to grab your patch when testing
things.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (26+ messages)  latest in thread

Message-ID: <Ygm4gC4ZN3TU0Bqt@paquier.xyz>
Permalink:  ../Ygm4gC4ZN3TU0Bqt@paquier.xyz/
Also on:    postgresql.org/message-id/Ygm4gC4ZN3TU0Bqt@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, myon@debian.org, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
  In-Reply-To: <Ygm4gC4ZN3TU0Bqt@paquier.xyz>
  References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org> <YgYw25OXV5men8Fj@msg.df7cb.de> <YgcDeben8eigBdNZ@paquier.xyz> <Ygd0jsxHreT1cig0@msg.df7cb.de> <2280644.1644683003@sss.pgh.pa.us> <Ygfg+7yePes1X/A9@msg.df7cb.de> <Ygm4gC4ZN3TU0Bqt@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox