pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
Date: Fri, 15 Apr 2022 16:49:28 +0200
Message-ID: <YlmF+IBmjAMxinHb@msg.df7cb.de> (raw)
In-Reply-To: <Ygm4gC4ZN3TU0Bqt@paquier.xyz>
References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org>
	<YgYw25OXV5men8Fj@msg.df7cb.de>
	<YgcDeben8eigBdNZ@paquier.xyz>
	<Ygd0jsxHreT1cig0@msg.df7cb.de>
	<2280644.1644683003@sss.pgh.pa.us>
	<Ygfg+7yePes1X/A9@msg.df7cb.de>
	<Ygm4gC4ZN3TU0Bqt@paquier.xyz>

Re: Michael Paquier
> > I was confusing that with this: The problem that led to the pg_config
> > patch years ago was that we have a /usr/bin/pg_config in
> > (non-major-version-dependant) libpq-dev, and
> > /usr/lib/postgresql/NN/bin/pg_config in the individual
> > postgresql-server-dev-NN packages, and iirc the /usr/bin version
> > didn't particularly like the other binaries being in
> > /usr/lib/postgresql/NN/bin/.
> > 
> > I guess it's time to revisit that problem now and see if it can be
> > solved more pretty today on our side.
> 
> If you can solve that, my take is that it could make things nicer in
> the long-run for some of the TAP test facilities.  Still, I'll try to
> look at a solution for this thread that does not interact badly with
> what you are doing, and I am going to grab your patch when testing
> things.

tl;dr: This is no longer an issue.

Since build-time testing broke again about two weeks ago due to
Debian's pg_config patch, I revisited the situation and found that the
patch is in fact no longer necessary to support pg_config in /usr/bin:

To support cross-compilation against libpq, some years ago I had
already replaced /usr/bin/pg_config (in libpq-dev) with a perl script
that collects path info at build time and outputs them statically at
run time [1]. The "real" /usr/lib/postgresql/15/bin/pg_config (in
postgresql-server-dev-15) is still the C version, now unpatched with
full relocatability support.

[1] https://salsa.debian.org/postgresql/postgresql-common/-/blob/master/server/postgresql.mk#L189-194
    https://salsa.debian.org/postgresql/postgresql-common/-/blob/master/server/pg_config.pl

Christoph





view thread (26+ messages)  latest in thread

Message-ID: <YlmF+IBmjAMxinHb@msg.df7cb.de>
Permalink:  ../YlmF+IBmjAMxinHb@msg.df7cb.de/
Also on:    postgresql.org/message-id/YlmF+IBmjAMxinHb@msg.df7cb.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: myon@debian.org, michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Add TAP test to automate the equivalent of check_guc
  In-Reply-To: <YlmF+IBmjAMxinHb@msg.df7cb.de>
  References: <E1nHbaO-0000MF-RO@gemulon.postgresql.org> <YgYw25OXV5men8Fj@msg.df7cb.de> <YgcDeben8eigBdNZ@paquier.xyz> <Ygd0jsxHreT1cig0@msg.df7cb.de> <2280644.1644683003@sss.pgh.pa.us> <Ygfg+7yePes1X/A9@msg.df7cb.de> <Ygm4gC4ZN3TU0Bqt@paquier.xyz> <YlmF+IBmjAMxinHb@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox