pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date: Sun, 1 May 2022 22:15:46 +0900
Message-ID: <Ym6IAq48gBBm5Ujv@paquier.xyz> (raw)
In-Reply-To: <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>
References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org>
	<14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>

On Sat, Apr 30, 2022 at 04:52:54PM -0400, Andrew Dunstan wrote:
> This appears to have been misconceived, at least in the case of MSVC
> builds, as I have just discovered. It is entirely possible to have the
> lz4 libraries installed and build with them but not have the .exe, and
> unlike the configure case the MSVC build system doesn't conduct any test
> for it, resulting in a nasty looking TAP test failure. I assume similar
> failures are possible with zstd and maybe gzip.

Okay, we could change the code of vcregress.pl so as the different ENV
commands (tar, zstd, lz4 or gzip) are assigned as follows for the sake
of the tests:
- If a ENV value is available, trust the environment/user and rely on
it.
- If a ENV value is not available, try to look for it in the
environment by launching a simple $command --version (-version should
be fine across all the commands currently in need of coverage?).
-- On failure, set ENV{command} to an empty string.
-- On success, set ENV{command} = "$command"

Does something like this look better to you?
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (11+ messages)  latest in thread

Message-ID: <Ym6IAq48gBBm5Ujv@paquier.xyz>
Permalink:  ../Ym6IAq48gBBm5Ujv@paquier.xyz/
Also on:    postgresql.org/message-id/Ym6IAq48gBBm5Ujv@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, andrew@dunslane.net
  Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
  In-Reply-To: <Ym6IAq48gBBm5Ujv@paquier.xyz>
  References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org> <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <Ym6IAq48gBBm5Ujv@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox