From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Date: Wed, 27 Jul 2022 19:25:47 +0900
Message-ID: <YuESq072I8cM2BDm@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGJBTGr8A6aW3ND-nEQPL1f3_RjSrfEDryki_bdGaJX2Vg@mail.gmail.com>
References: <E1oGPwj-001NZa-73@gemulon.postgresql.org>
<YuDAaGhZMOIL1FGs@paquier.xyz>
<CA+hUKGLZtCTgp4NTWV-wGbR2Nyag71=EfYTKjDKnk+fkhuFMHw@mail.gmail.com>
<CA+hUKGJz_ryOF2yTUok8n+O+EtPWfV6UKoAj64LOTUbRQfbVzA@mail.gmail.com>
<CA+hUKGJBTGr8A6aW3ND-nEQPL1f3_RjSrfEDryki_bdGaJX2Vg@mail.gmail.com>
On Wed, Jul 27, 2022 at 06:21:07PM +1200, Thomas Munro wrote:
> Erm, let me try that again, this time with the CloseTransientFile()
> also under the lock, so that we never have a file handle without a
> lock.
Right. The whole write_relmap_file() already happens while taking
RelationMappingLock, so that seems like a good idea for consistency at
the end (even if I remember that there is a patch floating around to
improve the concurrency of pgrename, which may become an easier move
now that we require Windows 10).
I have tested three runs and that was working here even if the
issue is sporadic, so more runs may be better to have more
confidence.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@gmail.com, rhaas@postgresql.org
Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
In-Reply-To: <YuESq072I8cM2BDm@paquier.xyz>
References: <E1oGPwj-001NZa-73@gemulon.postgresql.org> <YuDAaGhZMOIL1FGs@paquier.xyz> <CA+hUKGLZtCTgp4NTWV-wGbR2Nyag71=EfYTKjDKnk+fkhuFMHw@mail.gmail.com> <CA+hUKGJz_ryOF2yTUok8n+O+EtPWfV6UKoAj64LOTUbRQfbVzA@mail.gmail.com> <CA+hUKGJBTGr8A6aW3ND-nEQPL1f3_RjSrfEDryki_bdGaJX2Vg@mail.gmail.com> <YuESq072I8cM2BDm@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox