From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test failure
Date: Tue, 20 Sep 2022 10:25:41 +0900
Message-ID: <YykWlaJj3dphGBvR@paquier.xyz> (raw)
In-Reply-To: <20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
References: <E1oXuu7-0005bU-55@gemulon.postgresql.org>
<20220919213217.ptqfdlcc5idk5xup@awork3.anarazel.de>
<YykSmXbGi08agCRq@paquier.xyz>
<20220920011317.24bbsihqwn5dg7fi@awork3.anarazel.de>
On Mon, Sep 19, 2022 at 06:13:17PM -0700, Andres Freund wrote:
> I don't really see what'd race with what here? pg_upgrade has precise control
> over what's happening here, no?
A code path could have forgotten a fclose() for example, but this code
is rather old and close-proof as far as I know. Most of the log files
are used with redirections for external calls, though I don't see
how these could still be hold after pg_upgrade finishes, though :/
Could the use meson somewhat influence when running tests on Windows?
> I've only seen it once so far, but there haven't been many CI runs of the
> meson branch since rebasing ontop of the last changes to pg_upgrade.
Hmm, okay. Is that a specific branch in one of your public repos?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_upgrade test failure
In-Reply-To: <YykWlaJj3dphGBvR@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox