From: Michael Paquier <michael@paquier.xyz>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
Date: Wed, 20 Aug 2025 17:11:05 +0900
Message-ID: <aKWDGckk3K2ftiPw@paquier.xyz> (raw)
In-Reply-To: <202508191031.5ipojyuaswzt@alvherre.pgsql>
References: <476683.1755560289@sss.pgh.pa.us>
<202508191031.5ipojyuaswzt@alvherre.pgsql>
On Tue, Aug 19, 2025 at 12:31:14PM +0200, Alvaro Herrera wrote:
> Hmm, don't you find strange that dbcommands.h is still included there?
> I wondered about that and found out that we have get_database_name()
> declared there. It sort-of makes sense, because it was originally done
> by scanning pg_database, but since commit cb98e6fb8fd4 introduced a
> syscache for it, we can have this routine in lsyscache.c/h instead,
> where it feels more at home. It also seems more sensible to declare
> get_database_oid() in pg_database.h. After these two changes, a lot of
> files can stop including dbcommands.h. This seems a nice cleanup to me,
> and passes headerscheck.
>
> 33 files changed, 39 insertions(+), 56 deletions(-)
Indeed, that's a nice located cleanup.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, alvherre@kurilemu.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move SQL-callable code related to multixacts into its own file
In-Reply-To: <aKWDGckk3K2ftiPw@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox