pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots
Date: Wed, 19 Nov 2025 11:56:42 -0500
Message-ID: <aR32yptHe5SV9pX6@momjian.us> (raw)
In-Reply-To: <CA+Tgmoba9=y2qN+g_=xR3kD7i3Bp78q-+cZ-xO-jiYpC-ff0Jg@mail.gmail.com>
References: <E1vJuHW-006ZaM-2j@gemulon.postgresql.org>
	<gwo2ql4qlydwkmsurbz3gflnom5nq2p4wbbrz4xium7g75nnfp@4yohqyq5ijx5>
	<53n63x724ahx2nwx42bmivjlt67fpbyh44knx7jazodsqcs5av@umzjyyg3clpq>
	<aRc40Suvuda74Hmx@momjian.us>
	<pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts>
	<aRdBXmI7lmLkEaDf@momjian.us>
	<mcpsr6tz3yqosnstqce23ex4o6i6ych53eqmsun5r5nroz6nry@zruh2yt5bezm>
	<aRdO1k-G65U50w0L@momjian.us>
	<p5putsgwhwwdgphcrbfxip2v3hrvgjn5as5coluib7fghdd4kd@ekqxfrss5n2o>
	<CA+Tgmoba9=y2qN+g_=xR3kD7i3Bp78q-+cZ-xO-jiYpC-ff0Jg@mail.gmail.com>

On Wed, Nov 19, 2025 at 11:02:08AM -0500, Robert Haas wrote:
> On Fri, Nov 14, 2025 at 12:14 PM Andres Freund <andres@anarazel.de> wrote:
> > I'm rather baffled by the process here. You pushed a patch, without any
> > review, which also wasn't previously posted publicly, that made things
> > worse. Then, after you got pushback on that change, you posted another patch,
> > that got mildly negative feedback. Then you also pushed that change.
> 
> I'm not totally sure that we're in a worse place after these changes
> than we were before them, but I strongly agree that committing a
> change with no previous public discussion is a thing that generally
> should not happen.
> 
> I mean, if the buildfarm is broken, pushing a fix quickly is
> absolutely the right thing to do, but if you think the documentation
> needs improving, there's no reason not to discuss that on
> pgsql-hackers before pushing.

Yeah, I was trying to clean up what we had and I thought it was
no-controversial.  Obviously I was wrong.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.





view thread (12+ messages)

Message-ID: <aR32yptHe5SV9pX6@momjian.us>
Permalink:  ../aR32yptHe5SV9pX6@momjian.us/
Also on:    postgresql.org/message-id/aR32yptHe5SV9pX6@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: bruce@momjian.us, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots
  In-Reply-To: <aR32yptHe5SV9pX6@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox