From: Bruce Momjian <bruce@momjian.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots
Date: Fri, 14 Nov 2025 10:46:30 -0500
Message-ID: <aRdO1k-G65U50w0L@momjian.us> (raw)
In-Reply-To: <mcpsr6tz3yqosnstqce23ex4o6i6ych53eqmsun5r5nroz6nry@zruh2yt5bezm>
References: <E1vJuHW-006ZaM-2j@gemulon.postgresql.org>
<gwo2ql4qlydwkmsurbz3gflnom5nq2p4wbbrz4xium7g75nnfp@4yohqyq5ijx5>
<53n63x724ahx2nwx42bmivjlt67fpbyh44knx7jazodsqcs5av@umzjyyg3clpq>
<aRc40Suvuda74Hmx@momjian.us>
<pexmenhqptw5h4ma4qasz3cvjtynivxprqifgghdjtmkxdig2g@djg7bk2p6pts>
<aRdBXmI7lmLkEaDf@momjian.us>
<mcpsr6tz3yqosnstqce23ex4o6i6ych53eqmsun5r5nroz6nry@zruh2yt5bezm>
On Fri, Nov 14, 2025 at 09:55:37AM -0500, Andres Freund wrote:
> Hi,
>
> On 2025-11-14 09:49:02 -0500, Bruce Momjian wrote:
> > On Fri, Nov 14, 2025 at 09:25:20AM -0500, Andres Freund wrote:
> > > Hi,
> > >
> > > On 2025-11-14 09:12:33 -0500, Bruce Momjian wrote:
> > > > On Fri, Nov 14, 2025 at 09:05:07AM -0500, Andres Freund wrote:
> > > > > Hi,
> > > > >
> > > > > On 2025-11-14 09:02:12 -0500, Andres Freund wrote:
> > > > > > On 2025-11-14 13:56:06 +0000, Bruce Momjian wrote:
> > > > > > > doc: remove verbiage about "receiving" data from rep. slots
> > > > > > >
> > > > > > > The slots are just LSN markers, not something to receive from.
> > > > > >
> > > > > > I think this is wrong. Logical slots also preserve resources other than WAL.
> > > > >
> > > > > I also think that the complaint about slots not being something to receive
> > > > > from is simply wrong for logical slots.
> > > >
> > > > Uh, can you clarify since I can't find details on what they preserve.
> > >
> > > Slots (physical ones can, logical ones always do), prevent row cleanup on the
> > > primary.
> >
> > I see your point. How is the attached patch? The link right after the
> > modified text talks only about WAL retention, so I think we need
> > something in this sentence to say we do more than WAL retention for
> > logical replication slots.
>
> It's less wrong, but I don't think this is the right place to add more
> documentation about what replication slots do.
Patch applied. I can keep improving it as we get more ideas.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: bruce@momjian.us, andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots
In-Reply-To: <aRdO1k-G65U50w0L@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox