pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
Date: Mon, 5 Jan 2026 09:49:26 +0900
Message-ID: <aVsKluvcsYTIoMG4@paquier.xyz> (raw)
In-Reply-To: <1193764.1767573683@sss.pgh.pa.us>
References: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
	<1193764.1767573683@sss.pgh.pa.us>

On Sun, Jan 04, 2026 at 07:41:23PM -0500, Tom Lane wrote:
> This patch is not okay.  pg_config.h.in is a generated file and
> hand modifications in it will not do.
> 
> If we don't need these symbols anymore, the right fix is to remove
> the probes for these headers in the autoconf and meson scripts.

Oops, sorry for the brain fart.  How about the attached?  autoreconf
and autoheader seem to be OK with it.
--
Michael

Attachments:

fix_autoconf.patch (text/x-diff, 1.5K) download
diff --git a/configure b/configure
index 78597c6229a2..02e4ec7890f1 100755
--- a/configure
+++ b/configure
@@ -13669,7 +13669,7 @@ fi
 ## Header files
 ##
 
-for ac_header in atomic.h copyfile.h execinfo.h getopt.h ifaddrs.h mbarrier.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h uchar.h ucred.h xlocale.h
+for ac_header in copyfile.h execinfo.h getopt.h ifaddrs.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h uchar.h ucred.h xlocale.h
 do :
   as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
 ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header" "$ac_includes_default"
diff --git a/configure.ac b/configure.ac
index 2ccf410f94c5..b90a220a6358 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1501,12 +1501,10 @@ AC_SUBST(UUID_LIBS)
 ##
 
 AC_CHECK_HEADERS(m4_normalize([
-	atomic.h
 	copyfile.h
 	execinfo.h
 	getopt.h
 	ifaddrs.h
-	mbarrier.h
 	sys/epoll.h
 	sys/event.h
 	sys/personality.h
diff --git a/meson.build b/meson.build
index 467f7f005a6a..c3834a9dc8fa 100644
--- a/meson.build
+++ b/meson.build
@@ -2626,13 +2626,11 @@ endif
 # XXX: Might be worth conditioning some checks on the OS, to avoid doing
 # unnecessary checks over and over, particularly on windows.
 header_checks = [
-  'atomic.h',
   'copyfile.h',
   'crtdefs.h',
   'execinfo.h',
   'getopt.h',
   'ifaddrs.h',
-  'mbarrier.h',
   'strings.h',
   'sys/epoll.h',
   'sys/event.h',

  signature.asc (application/pgp-signature, 832B) download

view thread (6+ messages)  latest in thread

Message-ID: <aVsKluvcsYTIoMG4@paquier.xyz>
Permalink:  ../aVsKluvcsYTIoMG4@paquier.xyz/
Also on:    postgresql.org/message-id/aVsKluvcsYTIoMG4@paquier.xyz

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
  In-Reply-To: <aVsKluvcsYTIoMG4@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox