From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
Date: Sat, 31 Mar 2018 19:43:38 +0200 (CEST)
Message-ID: <alpine.DEB.2.20.1803311936450.23311@lancre> (raw)
In-Reply-To: <10686.1522514072@sss.pgh.pa.us>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
<32390.1522464534@sss.pgh.pa.us>
<alpine.DEB.2.20.1803310828100.23311@lancre>
<10686.1522514072@sss.pgh.pa.us>
>> I assumed that pg_strong_random is always available,
>
> ... which is wrong. Every other call of it is wrapped in
> #ifdef HAVE_STRONG_RANDOM, and so must this one be.
Indeed, I clearly misunderstood its usage pattern. I looked at its source
("src/port/pg_strong_random.c") where the function is always defined and
is documented as returning false if it does not find a strong random
source, so I though that checking for this was enough. But indeed its
compilation fails if no source is provided.
Thanks for the fix.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, teodor@sigaev.ru, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
In-Reply-To: <alpine.DEB.2.20.1803311936450.23311@lancre>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox