pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
To: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Respect permissions within logical replication.
Date: Sat, 8 Jan 2022 11:30:57 -0500
Message-ID: <b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net> (raw)
In-Reply-To: <YdlYfS/l+PQA0ehs@paquier.xyz>
References: <E1n61f6-0006DS-Ek@gemulon.postgresql.org>
	<Ydkfj5IsZg7mQR0g@paquier.xyz>
	<YdlYfS/l+PQA0ehs@paquier.xyz>


On 1/8/22 04:25, Michael Paquier wrote:
> On Sat, Jan 08, 2022 at 02:22:23PM +0900, Michael Paquier wrote:
>> 2) crake fails perl-check
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-01-08%2002%3A47%3A26
>>
>> All the failures are the same, because of the shape of the subroutine
>> definitions:
>> Jan 07 21:53:04 ./src/test/subscription/t/027_nosuperuser.pl:
>> Subroutine prototypes used at line 13, column 1.  See page 194 of
>> PBP.  ([Subroutines::ProhibitSubroutinePrototypes] Severity: 5)
> This issue is just caused by the way the subroutines are defined,
> meaning that the attached cools down pgperlcritic.  Any objections if
> I apply that to cool down crake?  Jeff, if you wish to do so, please
> feel free of course.



Please do this. Subroutine prototypes should only be used in very
restricted circumstances in Perl. I can't recall when I've ever needed them.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (7+ messages)  latest in thread

Message-ID: <b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net>
Permalink:  ../b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net/
Also on:    postgresql.org/message-id/b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, michael@paquier.xyz, jdavis@postgresql.org
  Subject: Re: pgsql: Respect permissions within logical replication.
  In-Reply-To: <b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net>
  References: <E1n61f6-0006DS-Ek@gemulon.postgresql.org> <Ydkfj5IsZg7mQR0g@paquier.xyz> <YdlYfS/l+PQA0ehs@paquier.xyz> <b920ffde-8d6e-d795-394e-aea53e4e910a@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox