pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve handling of inherited GENERATED expressions.
Date: Thu, 12 Jan 2023 16:41:40 -0500
Message-ID: <b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net> (raw)
In-Reply-To: <1340662.1673556269@sss.pgh.pa.us>
References: <E1pFi7q-003BDS-DH@gemulon.postgresql.org>
	<ff51607f-f3d7-688f-90be-4f3d16cefd40@dunslane.net>
	<CA+HiwqFoaxUs2pYao7MWLh1_WpgWK_is8wcrQHT+6JDwf7jN1Q@mail.gmail.com>
	<16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net>
	<950928.1673534760@sss.pgh.pa.us>
	<1340662.1673556269@sss.pgh.pa.us>


On 2023-01-12 Th 15:44, Tom Lane wrote:
> I wrote:
>> Yeah.  I think best bet may be to drop the problematic table(s),
>> as we've done for other de-supported DDL situations.  A quick
>> experiment suggests that
>> DROP TABLE gtest_normal_child;
>> DROP TABLE gtest_normal_child2;
>> should do it.
> Some testing here confirms that the attached patch is enough to
> un-break things for HEAD.  Since you mentioned you have some other
> quasi-urgent BF fixes, maybe the thing to do is to roll up a release
> now and then work on the bigger idea at leisure.
>
> 			


Thanks, that's almost exactly what I did to turn crake green.

I'll push out a release tomorrow.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (8+ messages)  latest in thread

Message-ID: <b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net>
Permalink:  ../b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net/
Also on:    postgresql.org/message-id/b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, tgl@sss.pgh.pa.us, amitlangote09@gmail.com
  Subject: Re: pgsql: Improve handling of inherited GENERATED expressions.
  In-Reply-To: <b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net>
  References: <E1pFi7q-003BDS-DH@gemulon.postgresql.org> <ff51607f-f3d7-688f-90be-4f3d16cefd40@dunslane.net> <CA+HiwqFoaxUs2pYao7MWLh1_WpgWK_is8wcrQHT+6JDwf7jN1Q@mail.gmail.com> <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net> <950928.1673534760@sss.pgh.pa.us> <1340662.1673556269@sss.pgh.pa.us> <b952a602-1ce0-ac7a-c10f-81dacdb675a8@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox