From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: testing dist tarballs
Date: Fri, 26 May 2023 09:02:33 +0200
Message-ID: <ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org> (raw)
In-Reply-To: <20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de>
References: <E1oDWqn-000ADG-P9@gemulon.postgresql.org>
<ZGzEAqjxkkoY3ooH@msg.df7cb.de>
<ZGzIYsCF0cpeAPWP@msg.df7cb.de>
<933499.1684853190@sss.pgh.pa.us>
<20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de>
<974623.1684867863@sss.pgh.pa.us>
<20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de>
On 24.05.23 23:24, Andres Freund wrote:
> First thing I noticed that 'make dist' doesn't work in a vpath, failing in a
> somewhat obscure way (likely because in a vpath build the the copy from the
> source dir doesn't include GNUMakefile). Do we expect it to work?
I don't think so.
> Separately, it's somewhat confusing that we include errcodes.h etc in
> src/backend/utils, rather than its final location, in src/include/utils. It
> works, even without perl, because copying the file doesn't require perl, it's
> just generating it...
The "copying" is actually a symlink, right? I don't think we want to
ship symlinks in the tarball?
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, andres@anarazel.de, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@lists.postgresql.org
Subject: Re: testing dist tarballs
In-Reply-To: <ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox