pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: testing dist tarballs
Date: Wed, 31 May 2023 06:52:03 -0400
Message-ID: <8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org> (raw)
In-Reply-To: <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de>
References: <E1oDWqn-000ADG-P9@gemulon.postgresql.org>
	<ZGzEAqjxkkoY3ooH@msg.df7cb.de>
	<ZGzIYsCF0cpeAPWP@msg.df7cb.de>
	<933499.1684853190@sss.pgh.pa.us>
	<20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de>
	<974623.1684867863@sss.pgh.pa.us>
	<20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de>
	<ccfbf843-574b-ec0a-d26a-090fc493af4b@eisentraut.org>
	<20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de>

On 27.05.23 14:47, Andres Freund wrote:
>>> Separately, it's somewhat confusing that we include errcodes.h etc in
>>> src/backend/utils, rather than its final location, in src/include/utils. It
>>> works, even without perl, because copying the file doesn't require perl, it's
>>> just generating it...
>>
>> The "copying" is actually a symlink, right?  I don't think we want to ship
>> symlinks in the tarball?
> 
> Fair point - still seems we should just create the files in the right
> directory instead of doing it in the wrong place and then creating symlinks to
> make them accessible...

Right.  I think the reason this was set up this way is that with make it 
is generally dubious to create target files outside of the current 
directory.






view thread (6+ messages)

Message-ID: <8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org>
Permalink:  ../8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org/
Also on:    postgresql.org/message-id/8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, andres@anarazel.de, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: testing dist tarballs
  In-Reply-To: <8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox