pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
Date: Wed, 23 Aug 2023 12:24:41 +0200
Message-ID: <e8bcb3f8-73b8-4761-22df-899cb5f429b1@eisentraut.org> (raw)
In-Reply-To: <E1qYXfk-000MI1-Ql@gemulon.postgresql.org>
References: <E1qYXfk-000MI1-Ql@gemulon.postgresql.org>

On 22.08.23 22:08, Jeff Davis wrote:
> Fix pg_dump assertion failure when dumping pg_catalog.
> 
> Commit 396d348b04 did not account for the default collation.
> 
> Also, use pg_log_warning() instead of Assert().

Looking at this:

     pg_log_warning("invalid collation \"%s\"", qcollname);

qcollname is already a quoted identifier, so this message would be 
doubly quoted.  Maybe you should use collinfo->dobj.name in the messages.

Also, for

     pg_fatal("unrecognized collation provider '%c'", collprovider[0]);

use double quotes.






view thread (6+ messages)  latest in thread

Message-ID: <e8bcb3f8-73b8-4761-22df-899cb5f429b1@eisentraut.org>
Permalink:  ../e8bcb3f8-73b8-4761-22df-899cb5f429b1@eisentraut.org/
Also on:    postgresql.org/message-id/e8bcb3f8-73b8-4761-22df-899cb5f429b1@eisentraut.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix pg_dump assertion failure when dumping pg_catalog.
  In-Reply-To: <e8bcb3f8-73b8-4761-22df-899cb5f429b1@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox