From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: Thu, 7 Apr 2022 08:18:05 -0400
Message-ID: <ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net> (raw)
In-Reply-To: <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de>
References: <E1ncMoW-000hhv-4s@gemulon.postgresql.org>
<20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de>
On 4/7/22 04:36, Andres Freund wrote:
> Hi,
>
> On 2022-04-07 07:44:20 +0000, Thomas Munro wrote:
>> Prefetch data referenced by the WAL, take II.
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-04-07%2008%3A17%3A27
> thinks that xlogpretcher.h doesn't include enough...
>
> I had added those checks to CI, but apparently somehow screwed that up.
>
> Or maybe it's the scripts that are screwed up? Because I don't see any error
> checking in headerscheck/cpluspluscheck. And indeed, locally they show the
> errors, but exit with 0.
Yeah, you can't rely on the exit status, if they produce output that
should be regarded as a failure (that's what crake does).
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, andres@anarazel.de, tmunro@postgresql.org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
In-Reply-To: <ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net>
References: <E1ncMoW-000hhv-4s@gemulon.postgresql.org> <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de> <ef12f73f-3d85-75bf-6728-6f03b77c8d61@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox