pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: rir <rirans@comcast.net>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: small patch
Date: Thu, 07 Oct 2021 16:24:16 -0400
Message-ID: <175281.1633638256@sss.pgh.pa.us> (raw)
In-Reply-To: <20211007200612.rkxxgeorw6w4fpjp@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
	<1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
	<20211007033905.pmsg5qnyqceepfva@localhost>
	<9f703511c57d6bb0f44f9a968414869854ae50ea.camel@cybertec.at>
	<20211007200612.rkxxgeorw6w4fpjp@localhost>

rir <rirans@comcast.net> writes:
> On Thu, Oct 07, 2021 at 07:58:47AM +0200, Laurenz Albe wrote:
>> Can you think of a way to modify the syntax diagram so that it
>> expresses that and still remains comprehensible?

> For myself,
>    'FETCH [ <direction> [ FROM | IN ] ] <cursor_name>'
> clearly indicates that 'direction' is optional.

Right, but if we don't say that <direction> can be
empty, then this diagram disallows

	FETCH FROM cursor_name

which in fact is legal.  I think however that we could make it read

	FETCH [ <direction> ] [ FROM | IN ] <cursor_name>'

and have a correct description without requiring <direction>
to be allowed to be empty.

BTW, as it stands, the diagram is ambiguous
because there are two ways to parse

	FETCH cursor_name

... is <direction> present but empty, or omitted altogether?

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <175281.1633638256@sss.pgh.pa.us>
Permalink:  ../175281.1633638256@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/175281.1633638256@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: tgl@sss.pgh.pa.us, rirans@comcast.net, laurenz.albe@cybertec.at, pgsql-docs@lists.postgresql.org
  Subject: Re: small patch
  In-Reply-To: <175281.1633638256@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox