pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: rir <rirans@comcast.net>
To: pgsql-docs@lists.postgresql.org
Subject: Re: small patch
Date: Mon, 04 Oct 2021 08:18:22 +0200
Message-ID: <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at> (raw)
In-Reply-To: <20211001163938.ifg4ayrsjwd7r6zr@localhost>
References: <20211001163938.ifg4ayrsjwd7r6zr@localhost>

On Fri, 2021-10-01 at 21:06 -0400, rir wrote:
> Minor changes to move.sgml and fetch.sgml.
> 
> The text 'or empty' is inconsistent by restating what the
> synopsis notation has expressed.
> 
> The comments on sharing a language feature, while
> likely helpful during review, seem verbose compared to
> the non-commenting in other similar files.

Thanks for the effort of preparing a patch.

However, I don't think that is an improvement:

- the comments pointing from MOVE to FETCH and vice versa are
  helpful for people who edit the documentation like you did

- we should retain "empty or one of", otherwise the following syntax
  would be undocumented:

      FETCH FROM c;

Yours,
Laurenz Albe






view thread (16+ messages)  latest in thread

Message-ID: <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>
Permalink:  ../1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at/
Also on:    postgresql.org/message-id/1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: laurenz.albe@cybertec.at, rirans@comcast.net, pgsql-docs@lists.postgresql.org
  Subject: Re: small patch
  In-Reply-To: <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox