From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Guillaume Lelarge <guillaume@lelarge.info>
Cc: Neil Conway <neilc@samurai.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Two fixes for plpgsql.sgml
Date: Wed, 28 Nov 2007 15:57:28 -0500 (EST)
Message-ID: <200711282057.lASKvSt19769@momjian.us> (raw)
In-Reply-To: <20923.1196282281@sss.pgh.pa.us>
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Agreed. I couldn't find any value to that phrase and couldn't find better
> > wording, so I removed it. Patch attached and applied.
>
> This is not an improvement.
>
> The point of the original wording is that you have to say
> RETURNS SETOF sometype
> you can't just say, eg,
> RETURNS SET
>
> Your new wording would lead the reader to the assumption that he can
> just declare a function as returning "set".
>
> Please revert the change.
I found the original confusing, as did the author, so I updated the docs
again.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Attachments:/rtmp/diff (text/x-diff, 1.1K) download
Index: plpgsql.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v
retrieving revision 1.119
diff -c -r1.119 plpgsql.sgml
*** plpgsql.sgml 28 Nov 2007 20:13:06 -0000 1.119
--- plpgsql.sgml 28 Nov 2007 20:56:17 -0000
***************
*** 132,141 ****
</para>
<para>
! <application>PL/pgSQL</> functions can also be declared to return
! a <quote>set</>, or table. Such a function generates its output by
! executing <command>RETURN NEXT</> for each desired element of the result
! set, or by using <command>RETURN QUERY</> to output the result of
evaluating a query.
</para>
--- 132,142 ----
</para>
<para>
! <application>PL/pgSQL</> functions can also be declared to return a
! group of values, either as a single row, or a group of rows, like a
! table. Such a function generates its output by executing
! <command>RETURN NEXT</> for each desired element of the result set,
! or by using <command>RETURN QUERY</> to output the result of
evaluating a query.
</para>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, guillaume@lelarge.info, neilc@samurai.com
Subject: Re: Two fixes for plpgsql.sgml
In-Reply-To: <200711282057.lASKvSt19769@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox