public inbox for [email protected]  

help / color / mirror / Atom feed

libpq-example.html needs to use <> includes
2+ messages / 2 participants
[nested] [flat]

* libpq-example.html needs to use <> includes
@ 2010-02-25 01:37 Josh Berkus <[email protected]>
  2010-02-27 03:41 ` Re: libpq-example.html needs to use <> includes Bruce Momjian <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Josh Berkus @ 2010-02-25 01:37 UTC (permalink / raw)
  To: pgsql-docs

All,

The libpq-example is using local includes for libpq-fe, instead of
library includes:

#include "libpq-fe.h"

I can't think of a single good reason for this, is there one?

--Josh Berkus



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: libpq-example.html needs to use <> includes
  2010-02-25 01:37 libpq-example.html needs to use <> includes Josh Berkus <[email protected]>
@ 2010-02-27 03:41 ` Bruce Momjian <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Bruce Momjian @ 2010-02-27 03:41 UTC (permalink / raw)
  To: Josh Berkus <[email protected]>; +Cc: pgsql-docs

Josh Berkus wrote:
> All,
> 
> The libpq-example is using local includes for libpq-fe, instead of
> library includes:
> 
> #include "libpq-fe.h"
> 
> I can't think of a single good reason for this, is there one?

Agreed, fixed with the attached, applied patch.

-- 
  Bruce Momjian  <[email protected]>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +


Attachments:

  [text/x-diff] /rtmp/diff (1.3K, 2-%2Frtmp%2Fdiff)
  download | inline diff:
Index: doc/src/sgml/libpq.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v
retrieving revision 1.302
diff -c -c -r1.302 libpq.sgml
*** doc/src/sgml/libpq.sgml	24 Feb 2010 15:54:31 -0000	1.302
--- doc/src/sgml/libpq.sgml	27 Feb 2010 03:40:36 -0000
***************
*** 7010,7016 ****
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include "libpq-fe.h"
  
  static void
  exit_nicely(PGconn *conn)
--- 7010,7016 ----
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include <libpq-fe.h>
  
  static void
  exit_nicely(PGconn *conn)
***************
*** 7158,7164 ****
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include "libpq-fe.h"
  
  static void
  exit_nicely(PGconn *conn)
--- 7158,7164 ----
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include <libpq-fe.h>
  
  static void
  exit_nicely(PGconn *conn)
***************
*** 7296,7302 ****
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include "libpq-fe.h"
  
  /* for ntohl/htonl */
  #include <netinet/in.h>
--- 7296,7302 ----
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include <libpq-fe.h>
  
  /* for ntohl/htonl */
  #include <netinet/in.h>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2010-02-27 03:41 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2010-02-25 01:37 libpq-example.html needs to use <> includes Josh Berkus <[email protected]>
2010-02-27 03:41 ` Bruce Momjian <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox