From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: milyutinma@gmail.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in pg_stat_replication view
Date: Tue, 4 Dec 2018 11:19:25 +0900
Message-ID: <20181204021925.GM3423@paquier.xyz> (raw)
In-Reply-To: <CAEepm=3rVm=krEhefk-o=e4KTG3ry_QMJWcn7DgFSGbOc4_UYQ@mail.gmail.com>
References: <27b3b80c-3615-2d76-02c5-44566b53136c@gmail.com>
<20181204001802.GK3423@paquier.xyz>
<CAEepm=3rVm=krEhefk-o=e4KTG3ry_QMJWcn7DgFSGbOc4_UYQ@mail.gmail.com>
On Tue, Dec 04, 2018 at 01:28:15PM +1300, Thomas Munro wrote:
> On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael@paquier.xyz> wrote:
>> Yes, you are right. It should be "on" as "remote_flush" is not a valid
>> value. remote_flush is listed in SyncCommitLevel though, so this makes
>> me wonder if we should also introduce a new value for this purpose
>> available for users. The fix you propose looks good to me. Any
>> opinions from others?
>
> +1 for the patch.
Thanks for confirming, Thomas. I'll go apply hopefully tomorrow if
nobody has objections.
> As for introducing remote_flush as the true name of the level, this
> was discussed but somehow went off-course and never made it to the
> finish line:
>
> https://www.postgresql.org/message-id/flat/CAEepm%3D3FFaanSS4sugG%2BApzq2tCVjEYCO2wOQBod2d7GWb%3DDvA...
Oh, I forgot this one. We may want to revive that... remote_flush is
more meaningful than on, especially since there are more and more
possible values for synchronous_commit.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@enterprisedb.com, milyutinma@gmail.com, pgsql-docs@lists.postgresql.org
Subject: Re: Typo in description of replay_lag attribute in pg_stat_replication view
In-Reply-To: <20181204021925.GM3423@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox