pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: emorley@heroku.com
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
Date: Wed, 30 Oct 2019 13:43:55 -0400
Message-ID: <20191030174355.GA23041@momjian.us> (raw)
In-Reply-To: <20191030042948.GB20808@paquier.xyz>
References: <157123155668.25311.9369950798665566339@wrigleys.postgresql.org>
	<20191017013310.GC5605@paquier.xyz>
	<20191024020544.GD8650@momjian.us>
	<20191030042948.GB20808@paquier.xyz>

On Wed, Oct 30, 2019 at 01:29:48PM +0900, Michael Paquier wrote:
> On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> > My reading of the commit message is that the error messages will just be
> > more helpful now, not that some things would now error that use to be
> > ignored.  I am still unclear exactly what the release notes should say.
> 
> Nay.  It could be worse as in some cases like for the keepalive
> parameters, the values would be just silently ignored.  Please let me
> suggest the attached for the release notes of REL_12_STABLE.

Thanks for the patch.  I slightly modified the wording and applied the
attached patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +

Attachments:


diff (text/plain, 1.1K) download
diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
new file mode 100644
index 126d614..337a7a2
*** a/doc/src/sgml/release-12.sgml
--- b/doc/src/sgml/release-12.sgml
*************** Author: Peter Eisentraut <peter_e@gmx.ne
*** 654,659 ****
--- 654,681 ----
       </para>
      </listitem>
  
+     <listitem>
+ <!--
+ Author: Michael Paquier <michael@paquier.xyz>
+ 2018-09-12 [e7a221797] Parse more strictly integer parameters from connection s
+ -->
+ 
+      <para>
+       Parse libpq integer connection parameters more strictly (Fabien
+       Coelho)
+      </para> 
+ 
+      <para>
+       In previous releases, using an incorrect integer value for
+       connection parameters <literal>connect_timeout</literal>,
+       <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+       <literal>keepalives_idle</literal>,
+       <literal>keepalives_interval</literal> and <literal>port</literal>
+       resulted in libpq either ignoring those values or failing with
+       incorrect error messages.
+      </para> 
+     </listitem>
+     
     </itemizedlist>
  
    </sect2>

view thread (6+ messages)  latest in thread

Message-ID: <20191030174355.GA23041@momjian.us>
Permalink:  ../20191030174355.GA23041@momjian.us/
Also on:    postgresql.org/message-id/20191030174355.GA23041@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: bruce@momjian.us, michael@paquier.xyz, emorley@heroku.com, pgsql-docs@lists.postgresql.org
  Subject: Re: PostgreSQL 12 release notes missing breaking change in libpq
  In-Reply-To: <20191030174355.GA23041@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox