pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: osdba <mailtch@163.com>
Cc: pgsql-docs@postgresql.org
Subject: Re: Document "59.2. Built-in Operator Classes" have a clerical error?
Date: Tue, 25 Aug 2020 13:44:03 +0900
Message-ID: <20200825044403.GC2017@paquier.xyz> (raw)
In-Reply-To: <20200824160100.GN26781@momjian.us>
References: <20200824142217.GH26781@momjian.us>
	<20200824155922.GA32094@alvherre.pgsql>
	<20200824160100.GN26781@momjian.us>

On Mon, Aug 24, 2020 at 12:01:00PM -0400, Bruce Momjian wrote:
> Sure, I can wait.  Is this the only place where it would make sense?

I think so.  If there are other places, it does not prevent improving
what we already know needs improvement.

FWIW, the layout I was thinking about is something like the patch
attached.  I have only patched GIN to give an idea of the shape of the
tables.  The PNG file attached is a screenshot of the HTML generated.
I know that we try to limit the use of morerows, but it seems much
better to me to use morerows for those pages here knowing the small
size of the tables.  We could split that into multiple tables instead,
still I find the single-table approach cleaner.
--
Michael

Attachments:


gin_ops_doc.png (image/png, 80.2K) download
  view image



doc-gin-opr-table.patch (text/x-diff, 2.9K) download
diff --git a/doc/src/sgml/gin.sgml b/doc/src/sgml/gin.sgml
index 2d862669c3..6fee0280be 100644
--- a/doc/src/sgml/gin.sgml
+++ b/doc/src/sgml/gin.sgml
@@ -85,43 +85,57 @@
     </thead>
     <tbody>
      <row>
-      <entry><literal>array_ops</literal></entry>
-      <entry><type>anyarray</type></entry>
-      <entry>
-       <literal>&amp;&amp;</literal>
-       <literal>&lt;@</literal>
-       <literal>=</literal>
-       <literal>@&gt;</literal>
-      </entry>
+      <entry morerows="3"><literal>array_ops</literal></entry>
+      <entry morerows="3"><type>anyarray</type></entry>
+      <entry><literal>&amp;&amp;(anyarray,anyarray)</literal></entry>
      </row>
      <row>
-      <entry><literal>jsonb_ops</literal></entry>
-      <entry><type>jsonb</type></entry>
-      <entry>
-       <literal>?</literal>
-       <literal>?&amp;</literal>
-       <literal>?|</literal>
-       <literal>@&gt;</literal>
-       <literal>@?</literal>
-       <literal>@@</literal>
-      </entry>
+      <entry><literal>@&gt;(anyarray,anyarray)</literal></entry>
      </row>
      <row>
-      <entry><literal>jsonb_path_ops</literal></entry>
-      <entry><type>jsonb</type></entry>
-      <entry>
-       <literal>@&gt;</literal>
-       <literal>@?</literal>
-       <literal>@@</literal>
-      </entry>
+      <entry><literal>&lt;@(anyarray,anyarray)</literal></entry>
      </row>
      <row>
-      <entry><literal>tsvector_ops</literal></entry>
-      <entry><type>tsvector</type></entry>
-      <entry>
-       <literal>@@</literal>
-       <literal>@@@</literal>
-      </entry>
+      <entry><literal>=(anyarray,anyarray)</literal></entry>
+     </row>
+     <row>
+      <entry morerows="5"><literal>jsonb_ops</literal></entry>
+      <entry morerows="5"><type>jsonb</type></entry>
+      <entry><literal>@&gt;(jsonb,jsonb)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>@?(jsonb,jsonpath)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>@@(jsonb,jsonpath)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>?(jsonb,text)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>?|(jsonb,text[])</literal></entry>
+     </row>
+     <row>
+      <entry><literal>?&amp;(jsonb,text[])</literal></entry>
+     </row>
+     <row>
+      <entry morerows="2"><literal>jsonb_path_ops</literal></entry>
+      <entry morerows="2"><type>jsonb</type></entry>
+      <entry><literal>@&gt;(jsonb,jsonb)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>@?(jsonb,jsonpath)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>@@(jsonb,jsonpath)</literal></entry>
+     </row>
+     <row>
+      <entry morerows="1"><literal>tsvector_ops</literal></entry>
+      <entry morerows="1"><type>tsvector</type></entry>
+      <entry><literal>@@(tsvector,tsquery)</literal></entry>
+     </row>
+     <row>
+      <entry><literal>@@@(tsvector,tsquery)</literal></entry>
      </row>
     </tbody>
    </tgroup>


  signature.asc (application/pgp-signature, 832B) download

view thread (28+ messages)  latest in thread

Message-ID: <20200825044403.GC2017@paquier.xyz>
Permalink:  ../20200825044403.GC2017@paquier.xyz/
Also on:    postgresql.org/message-id/20200825044403.GC2017@paquier.xyz

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: michael@paquier.xyz, bruce@momjian.us, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, mailtch@163.com
  Subject: Re: Document "59.2. Built-in Operator Classes" have a clerical error?
  In-Reply-To: <20200825044403.GC2017@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox