pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Euler Taveira <euler.taveira@2ndquadrant.com>
Cc: e.indrupskaya@postgrespro.ru
Cc: pgsql-docs@lists.postgresql.org
Subject: Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html
Date: Tue, 10 Nov 2020 19:23:12 -0500
Message-ID: <20201111002312.GE12947@momjian.us> (raw)
In-Reply-To: <2288763.1605050129@sss.pgh.pa.us>
References: <160379568081.24752.14096853446375954245@wrigleys.postgresql.org>
	<20201027165424.GO4951@momjian.us>
	<CAH503wC7R-gvecEGTZNgv9v04u9Z579xjgTzBJ-JKDiqxvWL_g@mail.gmail.com>
	<93414.1604070598@sss.pgh.pa.us>
	<20201110230636.GA12947@momjian.us>
	<2288763.1605050129@sss.pgh.pa.us>

On Tue, Nov 10, 2020 at 06:15:29PM -0500, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Fri, Oct 30, 2020 at 11:09:58AM -0400, Tom Lane wrote:
> >> Thinking about it from the perspective of someone dealing with an
> >> installation tree not a source tree, maybe the reference should
> >> be to "server/catalog/pg_type_d.h".  That might help disabuse
> >> anyone who's expecting to find it at that path in the git tree.
> 
> > I am confused what the "server/" prefix means in a path name.
> 
> That is the path underneath the installation "include" directory
> at which that file will be found.

Yep, it's there.  I thought I checked for an include/catalog install
directory, but obviously not well enough.

> > We currently say:
> 
> > 	The <acronym>OID</acronym>s of the built-in data types are defined in
> > 	the file <filename>src/include/catalog/pg_type_d.h</filename> in the
> > 	source tree.
> 
> Yeah, so also s/source tree/install tree/.

OK, here is a patch that mentions both.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Attachments:

pg_type.diff (text/x-diff, 712B) download diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml index 9ce32fb39b..73c6a6ea4d 100644 --- a/doc/src/sgml/libpq.sgml +++ b/doc/src/sgml/libpq.sgml @@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res, You can query the system table <literal>pg_type</literal> to obtain the names and properties of the various data types. The <acronym>OID</acronym>s of the built-in data types are defined - in the file <filename>src/include/catalog/pg_type_d.h</filename> - in the source tree. + in the file <filename>include/catalog/pg_type_d.h</filename> + in the compiled source directory and install directory. </para> </listitem> </varlistentry>

view thread (10+ messages)  latest in thread

Message-ID: <20201111002312.GE12947@momjian.us>
Permalink:  ../20201111002312.GE12947@momjian.us/
Also on:    postgresql.org/message-id/20201111002312.GE12947@momjian.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-docs@postgresql.org
  Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, euler.taveira@2ndquadrant.com, e.indrupskaya@postgrespro.ru, pgsql-docs@lists.postgresql.org
  Subject: Re: Missing file is mentioned on page https://www.postgresql.org/docs/13/libpq-exec.html
  In-Reply-To: <20201111002312.GE12947@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox