agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: elionescu@yahoo.com <elionescu@yahoo.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: incorrect (incomplete) description for "alter domain"
Date: Mon, 29 Jul 2024 10:58:06 -0400
Message-ID: <2585954.1722265086@sss.pgh.pa.us> (raw)
In-Reply-To: <CAKFQuwbZ3KDq3CtG0qtw7gVT4EWgmD8XFMktEFcruVs98ihCSw@mail.gmail.com>
References: <172225092461.915373.6103973717483380183@wrigleys.postgresql.org>
<CAKFQuwbZ3KDq3CtG0qtw7gVT4EWgmD8XFMktEFcruVs98ihCSw@mail.gmail.com>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Monday, July 29, 2024, PG Doc comments form <noreply@postgresql.org>
> wrote:
>> In the Synopsis section of
>> https://www.postgresql.org/docs/current/sql-alterdomain.html
>> this is incorrect (incomplete):
>> "ALTER DOMAIN name ADD domain_constraint [ NOT VALID ]"
>> It should be
>> "ALTER DOMAIN name ADD CONSTRAINT domain_constraint [ NOT VALID ]"
> The definition of “domain_constraint” includes the optional “constraint
> constraint_name” clause. Though reading the page and seeing the number of
> times we say “alter domain add constraint” I even more inclined to agree
> that bringing the word constraint there is desirable. I am not a huge fan
> of the indirect syntax references anyway.
I think the page is technically correct, but I'm inclined to duplicate
this text from the CREATE DOMAIN page:
where domain_constraint is:
[ CONSTRAINT constraint_name ]
{ NOT NULL | NULL | CHECK (expression) }
rather than making readers go look that up. Is that the same thing
you're thinking, or did you have a different idea?
regards, tom lane
view thread (9+ messages) latest in thread
Message-ID: <2585954.1722265086@sss.pgh.pa.us>
Permalink: ../2585954.1722265086@sss.pgh.pa.us/
Also on: postgresql.org/message-id/2585954.1722265086@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, elionescu@yahoo.com, pgsql-docs@lists.postgresql.org
Subject: Re: incorrect (incomplete) description for "alter domain"
In-Reply-To: <2585954.1722265086@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox