From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: elionescu@yahoo.com <elionescu@yahoo.com>
Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
Subject: Re: incorrect (incomplete) description for "alter domain"
Date: Fri, 1 Nov 2024 13:54:48 -0400
Message-ID: <ZyUV6GXxWZjeUe5r@momjian.us> (raw)
In-Reply-To: <ZxAsGmcyYk8es5ac@momjian.us>
References: <172225092461.915373.6103973717483380183@wrigleys.postgresql.org>
<CAKFQuwbZ3KDq3CtG0qtw7gVT4EWgmD8XFMktEFcruVs98ihCSw@mail.gmail.com>
<2585954.1722265086@sss.pgh.pa.us>
<2596729.1722266261@sss.pgh.pa.us>
<ZxAsGmcyYk8es5ac@momjian.us>
On Wed, Oct 16, 2024 at 05:11:54PM -0400, Bruce Momjian wrote:
> > Actually, there *is* a bug in the description, because experimentation
> > shows that CREATE DOMAIN accepts NULL in this syntax (as advertised)
> > but ALTER DOMAIN does not. We could alternatively decide that that's
> > a code bug and make ALTER DOMAIN take it, but I don't think it's worth
> > any effort (and this behavior may actually have been intentional, too).
> > I think we should just add
> >
> > where domain_constraint is:
> >
> > [ CONSTRAINT constraint_name ]
> > { NOT NULL | CHECK (expression) }
> >
> > to the ALTER DOMAIN page, and then remove the claim that it's
> > identical to CREATE DOMAIN.
>
> I have written the attached patch to document this. I assume this
> should be backpatched to PG 12.
Patch applied back to PG 12.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-docs@postgresql.org
Cc: bruce@momjian.us, tgl@sss.pgh.pa.us, david.g.johnston@gmail.com, elionescu@yahoo.com, pgsql-docs@lists.postgresql.org
Subject: Re: incorrect (incomplete) description for "alter domain"
In-Reply-To: <ZyUV6GXxWZjeUe5r@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox