pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedAdd missing meson arguments in docs
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2023-02-22 1a943d03d6 doc: Add missing values for meson options -Dcassert and -Db_coverage
* Add missing meson arguments in docs
@ 2023-02-21 09:40 Jelte Fennema <me@jeltef.nl>
0 siblings, 1 reply; 4+ messages in thread
From: Jelte Fennema @ 2023-02-21 09:40 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
The -Dcassert and -Db_coverage of the meson build didn't show in the
docs that they needed to be passed true or false. All other options
specified the arguments they expected. This patch fixes that.
Attachments:
0001-Add-missing-meson-arguments-in-docs.patch (application/octet-stream, 1.3K) download
From 01d8d5de9775cdf8a40a9665c623e60d5b92da14 Mon Sep 17 00:00:00 2001
From: Jelte Fennema <jelte.fennema@microsoft.com>
Date: Tue, 21 Feb 2023 10:32:27 +0100
Subject: [PATCH] Add missing meson arguments in docs
The -Dcassert and -Db_coverage of the meson build didn't show in the
docs that they needed to be passed true or false. All other options
specified the arguments they expected. This fixes that.
---
doc/src/sgml/installation.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index aa7c782c3f2..0ed35d99e91 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -3034,7 +3034,7 @@ ninja install
</varlistentry>
<varlistentry id="configure-cassert-meson">
- <term><option>-Dcassert</option></term>
+ <term><option>-Dcassert={ true | false }</option></term>
<listitem>
<para>
Enables <firstterm>assertion</firstterm> checks in the server, which
@@ -3075,7 +3075,7 @@ ninja install
</varlistentry>
<varlistentry id="configure-b-coverage-meson">
- <term><option>-Db_coverage</option></term>
+ <term><option>-Db_coverage={ true | false }</option></term>
<listitem>
<para>
If using GCC, all programs and libraries are compiled with
--
2.34.1
* Re: Add missing meson arguments in docs
@ 2023-02-22 01:57 Michael Paquier <michael@paquier.xyz>
parent: Jelte Fennema <me@jeltef.nl>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2023-02-22 01:57 UTC (permalink / raw)
To: Jelte Fennema <me@jeltef.nl>; +Cc: pgsql-docs@lists.postgresql.org
On Tue, Feb 21, 2023 at 10:40:12AM +0100, Jelte Fennema wrote:
> The -Dcassert and -Db_coverage of the meson build didn't show in the
> docs that they needed to be passed true or false. All other options
> specified the arguments they expected. This patch fixes that.
Indeed, values have to be specified after the equal sign of each
option, so applied what you are suggesting here.
-Db_coverage is part of the core options of meson because it is not
listed in meson_options.txt, no? Documenting the switch is fine, but
it seems like we lack contents here. The paragraph describing
-Db_coverage links to regress-coverage, still this only has
instructions for ./configure. Shouldn't we have some docs to show one
how to achieve the same with meson? I'd guess that a separate section
for meson would make the most sense, for as long as we support both
methods in parallel.
https://wiki.postgresql.org/wiki/Meson tells nothing about that, for
one.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Add missing meson arguments in docs
@ 2023-02-22 08:24 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 4+ messages in thread
From: Peter Eisentraut @ 2023-02-22 08:24 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; Jelte Fennema <me@jeltef.nl>; +Cc: pgsql-docs@lists.postgresql.org
On 22.02.23 02:57, Michael Paquier wrote:
> -Db_coverage is part of the core options of meson because it is not
> listed in meson_options.txt, no? Documenting the switch is fine, but
> it seems like we lack contents here. The paragraph describing
> -Db_coverage links to regress-coverage, still this only has
> instructions for ./configure. Shouldn't we have some docs to show one
> how to achieve the same with meson? I'd guess that a separate section
> for meson would make the most sense, for as long as we support both
> methods in parallel.
Yeah, this is just in the long tail of things to work through.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Add missing meson arguments in docs
@ 2023-02-28 08:40 Michael Paquier <michael@paquier.xyz>
parent: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2023-02-28 08:40 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>; +Cc: Jelte Fennema <me@jeltef.nl>; pgsql-docs@lists.postgresql.org
On Wed, Feb 22, 2023 at 09:24:37AM +0100, Peter Eisentraut wrote:
> Yeah, this is just in the long tail of things to work through.
I am going through that, and found out what can be done to do coverage
reports. I will post a patch separately on -hackers.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-02-28 08:40 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-21 09:40 Add missing meson arguments in docs Jelte Fennema <me@jeltef.nl>
2023-02-22 01:57 ` Michael Paquier <michael@paquier.xyz>
2023-02-22 08:24 ` Peter Eisentraut <peter.eisentraut@enterprisedb.com>
2023-02-28 08:40 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox