public inbox for [email protected]
help / color / mirror / Atom feedFrom: Charles Clavadetscher <[email protected]>
To: Stephen Frost <[email protected]>
Cc: [email protected]
Subject: Re: [DOCS] Missing COMMENT ON POLICY
Date: Sun, 13 Sep 2015 18:35:49 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>
Hi Stephen
On 13/09/2015 16:56, Stephen Frost wrote:
> Charles,
>
> * Charles Clavadetscher ([email protected]) wrote:
>> I noticed that the position of the parameter "policy_name" in the
>> description list of parameters was not at the (alphabetically)
>> correct position. I changed that and the result is attached.
>
> Thanks!
>
>> I think/hope that is now all correct.
>
> We generally prefer one complete patch which represents the total set
> of changes to a lot of individual little patches which build on each
> other.
>
> If you're using git and have these patches on a branch as different
> commits, you can do an interactive rebase to squash them all together,
> like this:
>
> git rebase -i
>
> That will open an editor and then you can choose the action to take for
> each patch. Generally, I'll make the first patch 'reword' and the
> rest 'squash'. Saving and exiting the editor will then take you to
> another editor session where you'll have an opportunity to reword the
> commit message (to incorporate all of the changes).
>
> Once all of that's done, you can use 'git format-patch' to create a file
> which includes the commit message and the patch. I generally run it
> like so:
>
> git format-patch @{u} --stdout > ~/patches/filename-for-patch.patch
>
> Hopefully that helps.
Yes, that helped a lot! In the attachment now a single patch file with
all changes.
Thank you a lot. BTW, looking forward to the server programming workshop
in Vienna.
Bye
Charles
--
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[application/softgrid-patch] update_comment_doc_with_policy.patch (3.1K, 2-update_comment_doc_with_policy.patch)
download | inline diff:
From e513183a7ed539cd341c62550ac3a6bbaa471c5e Mon Sep 17 00:00:00 2001
From: Charles Clavadetscher <[email protected]>
Date: Sun, 13 Sep 2015 11:02:25 +0200
Subject: [PATCH] Addition of POLICY to list of COMMENT objects, parameter
lists and examples.
Addition of defintions and an example for COMMENT ON POLICY.
Move of parameter description line to correct position.
---
doc/src/sgml/ref/comment.sgml | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/ref/comment.sgml b/doc/src/sgml/ref/comment.sgml
index 1030738..3321d4b 100644
--- a/doc/src/sgml/ref/comment.sgml
+++ b/doc/src/sgml/ref/comment.sgml
@@ -43,6 +43,7 @@ COMMENT ON
OPERATOR <replaceable class="PARAMETER">operator_name</replaceable> (<replaceable class="PARAMETER">left_type</replaceable>, <replaceable class="PARAMETER">right_type</replaceable>) |
OPERATOR CLASS <replaceable class="PARAMETER">object_name</replaceable> USING <replaceable class="parameter">index_method</replaceable> |
OPERATOR FAMILY <replaceable class="PARAMETER">object_name</replaceable> USING <replaceable class="parameter">index_method</replaceable> |
+ POLICY <replaceable class="PARAMETER">policy_name</replaceable> ON <replaceable class="PARAMETER">table_name</replaceable> |
[ PROCEDURAL ] LANGUAGE <replaceable class="PARAMETER">object_name</replaceable> |
ROLE <replaceable class="PARAMETER">object_name</replaceable> |
RULE <replaceable class="PARAMETER">rule_name</replaceable> ON <replaceable class="PARAMETER">table_name</replaceable> |
@@ -113,6 +114,7 @@ COMMENT ON
<term><replaceable class="parameter">constraint_name</replaceable></term>
<term><replaceable class="parameter">function_name</replaceable></term>
<term><replaceable class="parameter">operator_name</replaceable></term>
+ <term><replaceable class="parameter">policy_name</replaceable></term>
<term><replaceable class="parameter">rule_name</replaceable></term>
<term><replaceable class="parameter">trigger_name</replaceable></term>
<listitem>
@@ -133,9 +135,9 @@ COMMENT ON
<term><replaceable class="parameter">domain_name</replaceable></term>
<listitem>
<para>
- When creating a comment on a constraint on a table or a domain, these
- parameters specify the name of the table or domain on which the
- constraint is defined.
+ When creating a comment on a constraint, a table, a domain or
+ a policy these parameters specify the name of the table or domain on
+ which the constraint is defined.
</para>
</listitem>
</varlistentry>
@@ -315,6 +317,7 @@ COMMENT ON OPERATOR ^ (text, text) IS 'Performs intersection of two texts';
COMMENT ON OPERATOR - (NONE, integer) IS 'Unary minus';
COMMENT ON OPERATOR CLASS int4ops USING btree IS '4 byte integer operators for btrees';
COMMENT ON OPERATOR FAMILY integer_ops USING btree IS 'all integer operators for btrees';
+COMMENT ON POLICY my_policy ON mytable IS 'Filter rows by users';
COMMENT ON ROLE my_role IS 'Administration group for finance tables';
COMMENT ON RULE my_rule ON my_table IS 'Logs updates of employee records';
COMMENT ON SCHEMA my_schema IS 'Departmental data';
--
1.9.1
view thread (11+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [DOCS] Missing COMMENT ON POLICY
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox