public inbox for [email protected]  

help / color / mirror / Atom feed

From: Erik Wienhold <[email protected]>
To: jian he <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Bruce Momjian <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected]
Subject: Re: Use uppercase keywords in foreign key tutorial
Date: Mon, 10 Nov 2025 04:40:25 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>
References: <CAApHDvqR+_EU0mxrmS-AieE_8ovqtmnsJSOk-oq-Rdk3JzNWOg@mail.gmail.com>
	<[email protected]>
	<CAApHDvoqh_K2KTocwWYrGw5vLubnPnTzd1SvYTTonQ=vUXP7Ug@mail.gmail.com>
	<[email protected]>
	<CAApHDvraaZLdTm4XTLkgGhUwecpmNm1dOJMcEToak-Bh5742hQ@mail.gmail.com>
	<[email protected]>
	<CAApHDvqSiqmZbdDpZ_JhL5TbXNvKCLt1-Wk5j=4uRPoV0hd9hQ@mail.gmail.com>
	<[email protected]>
	<CAApHDvokYxXGORORfF_uP2PbaF-UagV-m3yySOfjzuqrVmWkCg@mail.gmail.com>
	<CACJufxG5UaQtoYFQKdMCYjpz_5Kggvdgm1gVEW4sNEa_W__FKA@mail.gmail.com>

On 2025-11-10 04:15 +0100, jian he wrote:
> On Thu, Nov 6, 2025 at 11:06 AM David Rowley <[email protected]> wrote:
> >
> > I reviewed this and double checked you left "uPDaTE" in [1]. Found no
> > issues, so pushed.
> >
> 
> in doc/src/sgml/func/func-matching.sgml
> 
> <synopsis>
> substring(<replaceable>string</replaceable> similar
> <replaceable>pattern</replaceable> escape
> <replaceable>escape-character</replaceable>)
> </synopsis>
>     or using the now obsolete SQL:1999 syntax:
> <synopsis>
> substring(<replaceable>string</replaceable> from
> <replaceable>pattern</replaceable> for
> <replaceable>escape-character</replaceable>)
> </synopsis>
>     or as a plain three-argument function:
> <synopsis>
> substring(<replaceable>string</replaceable>,
> <replaceable>pattern</replaceable>,
> <replaceable>escape-character</replaceable>)
> </synopsis>
> 
> key word: "similar", "escape", "from", "for" within the above synopsis
> section need uppercase too?

Thanks, good catch.  Not surprised that I've missed those because it
already took me a couple of rounds to find everything that's in the
previous patch.  Here's another patch.

-- 
Erik Wienhold

diff --git a/doc/src/sgml/func/func-matching.sgml b/doc/src/sgml/func/func-matching.sgml
index 91a0b7ca0de..f466860ddb0 100644
--- a/doc/src/sgml/func/func-matching.sgml
+++ b/doc/src/sgml/func/func-matching.sgml
@@ -369,11 +369,11 @@
     regular expression pattern.  The function can be written according
     to standard SQL syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> similar <replaceable>pattern</replaceable> escape <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> SIMILAR <replaceable>pattern</replaceable> ESCAPE <replaceable>escape-character</replaceable>)
 </synopsis>
     or using the now obsolete SQL:1999 syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> from <replaceable>pattern</replaceable> for <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> FROM <replaceable>pattern</replaceable> FOR <replaceable>escape-character</replaceable>)
 </synopsis>
     or as a plain three-argument function:
 <synopsis>


Attachments:

  [text/plain] upcase-keywords-in-func-matching.patch (1.0K, 2-upcase-keywords-in-func-matching.patch)
  download | inline diff:
diff --git a/doc/src/sgml/func/func-matching.sgml b/doc/src/sgml/func/func-matching.sgml
index 91a0b7ca0de..f466860ddb0 100644
--- a/doc/src/sgml/func/func-matching.sgml
+++ b/doc/src/sgml/func/func-matching.sgml
@@ -369,11 +369,11 @@
     regular expression pattern.  The function can be written according
     to standard SQL syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> similar <replaceable>pattern</replaceable> escape <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> SIMILAR <replaceable>pattern</replaceable> ESCAPE <replaceable>escape-character</replaceable>)
 </synopsis>
     or using the now obsolete SQL:1999 syntax:
 <synopsis>
-substring(<replaceable>string</replaceable> from <replaceable>pattern</replaceable> for <replaceable>escape-character</replaceable>)
+substring(<replaceable>string</replaceable> FROM <replaceable>pattern</replaceable> FOR <replaceable>escape-character</replaceable>)
 </synopsis>
     or as a plain three-argument function:
 <synopsis>

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use uppercase keywords in foreign key tutorial
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox